Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing newlines in DataFormats modules #44230

Merged
merged 15 commits into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DataFormats/Common/test/exTrie.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -345,4 +345,4 @@ cacj 9
)";
edm::iterateTrieLeaves(pr, *trie.initialNode());
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@

HFdepthTwoParameterA = cms.vdouble(0.002861, 0.004168, 0.006400, 0.008388, 0.011601, 0.014425, 0.018633, 0.023232, 0.028274, 0.035447, 0.051579, 0.086593),
HFdepthTwoParameterB = cms.vdouble(-0.000002, -0.000000, -0.000007, -0.000006, -0.000002, 0.000001, 0.000019, 0.000031, 0.000067, 0.000012, 0.000157, -0.000003)
)
)
2 changes: 1 addition & 1 deletion DataFormats/HepMCCandidate/doc/HepMCCandidate.doc
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ Complete.

<hr>
Last updated: @DATE@ L. Lista
*/
*/
2 changes: 1 addition & 1 deletion DataFormats/L1Scouting/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
<use name="DataFormats/Common"/>
<export>
<lib name="1"/>
</export>
</export>
2 changes: 1 addition & 1 deletion DataFormats/L1Scouting/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
Any changes to the L1 scouting data formats must be backwards compatible.
In order to ensure the L1 Scouting formats can be read by future CMSSW releases,
there is a `TestWriteL1ScoutingDataFormats` unit test, which makes use of the `TestReadL1Scouting` analyzer and the `TestWriteL1Scouting` producer.
The unit test checks that objects can be written and read properly.
The unit test checks that objects can be written and read properly.
2 changes: 1 addition & 1 deletion DataFormats/L1Scouting/interface/L1ScoutingCalo.h
Original file line number Diff line number Diff line change
Expand Up @@ -195,4 +195,4 @@ namespace l1ScoutingRun3 {
typedef OrbitCollection<BxSums> BxSumsOrbitCollection;

} // namespace l1ScoutingRun3
#endif // DataFormats_L1Scouting_L1ScoutingCalo_h
#endif // DataFormats_L1Scouting_L1ScoutingCalo_h
2 changes: 1 addition & 1 deletion DataFormats/L1Scouting/interface/L1ScoutingMuon.h
Original file line number Diff line number Diff line change
Expand Up @@ -92,4 +92,4 @@ namespace l1ScoutingRun3 {

} // namespace l1ScoutingRun3

#endif // DataFormats_L1Scouting_L1ScoutingMuon_h
#endif // DataFormats_L1Scouting_L1ScoutingMuon_h
2 changes: 1 addition & 1 deletion DataFormats/L1Scouting/src/classes.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@

#include "DataFormats/L1Scouting/interface/OrbitCollection.h"
#include "DataFormats/L1Scouting/interface/L1ScoutingMuon.h"
#include "DataFormats/L1Scouting/interface/L1ScoutingCalo.h"
#include "DataFormats/L1Scouting/interface/L1ScoutingCalo.h"
2 changes: 1 addition & 1 deletion DataFormats/L1Scouting/src/classes_def.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@
<class name="edm::Wrapper<l1ScoutingRun3::MuonOrbitCollection>"/>
<class name="edm::Wrapper<l1ScoutingRun3::TauOrbitCollection>"/>

</lcgdict>
</lcgdict>
2 changes: 1 addition & 1 deletion DataFormats/L1Scouting/test/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
<use name="FWCore/Utilities"/>
</library>

<test name="TestL1ScoutingFormat" command="TestL1ScoutingFormat.sh"/>
<test name="TestL1ScoutingFormat" command="TestL1ScoutingFormat.sh"/>
2 changes: 1 addition & 1 deletion DataFormats/L1Scouting/test/TestL1ScoutingFormat.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ oldFile="testL1Scouting_v3_v3_v3_v3_v3_13_3_0_pre5.root"
inputfile=$(edmFileInPath DataFormats/L1Scouting/data/$oldFile) || die "Failure edmFileInPath DataFormats/L1Scouting/data/$oldFile" $?
cmsRun ${LOCAL_TEST_DIR}/read_L1Scouting_cfg.py "$inputfile" || die "Failed to read old file $oldFile" $?

exit 0
exit 0
2 changes: 1 addition & 1 deletion DataFormats/L1Scouting/test/TestReadL1Scouting.cc
Original file line number Diff line number Diff line change
Expand Up @@ -330,4 +330,4 @@ namespace edmtest {
} // namespace edmtest

using edmtest::TestReadL1Scouting;
DEFINE_FWK_MODULE(TestReadL1Scouting);
DEFINE_FWK_MODULE(TestReadL1Scouting);
2 changes: 1 addition & 1 deletion DataFormats/L1Scouting/test/TestWriteL1Scouting.cc
Original file line number Diff line number Diff line change
Expand Up @@ -189,4 +189,4 @@ namespace edmtest {
} // namespace edmtest

using edmtest::TestWriteL1Scouting;
DEFINE_FWK_MODULE(TestWriteL1Scouting);
DEFINE_FWK_MODULE(TestWriteL1Scouting);
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@
)

process.path = cms.Path(process.l1ScoutingTestProducer)
process.endPath = cms.EndPath(process.out)
process.endPath = cms.EndPath(process.out)
2 changes: 1 addition & 1 deletion DataFormats/L1Scouting/test/read_L1Scouting_cfg.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@
)

process.path = cms.Path(process.l1ScoutingTestAnalyzer)
process.endPath = cms.EndPath(process.out)
process.endPath = cms.EndPath(process.out)
2 changes: 1 addition & 1 deletion DataFormats/L1ScoutingRawData/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
<use name="DataFormats/FEDRawData"/>
<export>
<lib name="1"/>
</export>
</export>
2 changes: 1 addition & 1 deletion DataFormats/L1ScoutingRawData/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
Any changes to the L1 scouting raw data `SDSRawDataCollection` must be backwards compatible.
In order to ensure the L1 Scouting raw data formats can be read by future CMSSW releases,
there is a `TestSDSRawDataCollectionFormat` unit test, which makes use of the `TestReadSDSRawDataCollection` analyzer and the `TestWriteSDSRawDataCollection` producer.
The unit test checks that objects can be written and read properly.
The unit test checks that objects can be written and read properly.
2 changes: 1 addition & 1 deletion DataFormats/L1ScoutingRawData/interface/SDSNumbering.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ class SDSNumbering {
static constexpr int CaloTCPMaxSDSID = 29;
};

#endif // L1ScoutingRawData_SDSNumbering_h
#endif // L1ScoutingRawData_SDSNumbering_h
2 changes: 1 addition & 1 deletion DataFormats/L1ScoutingRawData/src/classes.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "DataFormats/Common/interface/Wrapper.h"
// #include "DataFormats/Common/interface/RefProd.h"

#include "DataFormats/L1ScoutingRawData/interface/SDSRawDataCollection.h"
#include "DataFormats/L1ScoutingRawData/interface/SDSRawDataCollection.h"
2 changes: 1 addition & 1 deletion DataFormats/L1ScoutingRawData/src/classes_def.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
<version ClassVersion="3" checksum="2352873727"/>
</class>
<class name="edm::Wrapper<SDSRawDataCollection>" splitLevel="0"/>
</lcgdict>
</lcgdict>
2 changes: 1 addition & 1 deletion DataFormats/L1ScoutingRawData/test/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@
<use name="FWCore/Utilities"/>
</library>

<test name="TestSDSRawDataCollectionFormat" command="TestSDSRawDataCollectionFormat.sh"/>
<test name="TestSDSRawDataCollectionFormat" command="TestSDSRawDataCollectionFormat.sh"/>
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,4 @@ namespace edmtest {
} // namespace edmtest

using edmtest::TestReadSDSRawDataCollection;
DEFINE_FWK_MODULE(TestReadSDSRawDataCollection);
DEFINE_FWK_MODULE(TestReadSDSRawDataCollection);
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ oldFile="testSDSRawDataCollection_v3_CMSSW_13_3_0_pre5.root"
inputfile=$(edmFileInPath DataFormats/L1ScoutingRawData/data/$oldFile) || die "Failure edmFileInPath DataFormats/L1ScoutingRawData/data/$oldFile" $?
cmsRun ${LOCAL_TEST_DIR}/read_SDSRawDataCollection_cfg.py "$inputfile" || die "Failed to read old file $oldFile" $?

exit 0
exit 0
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,4 @@ namespace edmtest {
} // namespace edmtest

using edmtest::TestWriteSDSRawDataCollection;
DEFINE_FWK_MODULE(TestWriteSDSRawDataCollection);
DEFINE_FWK_MODULE(TestWriteSDSRawDataCollection);
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@
)

process.path = cms.Path(process.sdsRawDataCollectionProducer)
process.endPath = cms.EndPath(process.out)
process.endPath = cms.EndPath(process.out)
Original file line number Diff line number Diff line change
Expand Up @@ -149,4 +149,4 @@ namespace l1tp2 {

} // namespace l1tp2

#endif
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,4 @@ namespace l1tp2 {

} // namespace l1tp2

#endif
#endif
Original file line number Diff line number Diff line change
Expand Up @@ -94,4 +94,4 @@ namespace l1tp2 {

} // namespace l1tp2

#endif
#endif
2 changes: 1 addition & 1 deletion DataFormats/L1TrackTrigger/interface/TTDTC.h
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,4 @@ class TTDTC {
tt::StreamsStub streams_;
};

#endif
#endif
2 changes: 1 addition & 1 deletion DataFormats/L1TrackTrigger/test/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
<use name="DataFormats/L1TrackTrigger"/>
<use name="DataFormats/TestObjects"/>
</library>
</environment>
</environment>
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@

process.dummyAna = cms.EDAnalyzer("TTTrackTrackWordDummyOneAnalyzer")

process.p = cms.Path(process.dummyAna)
process.p = cms.Path(process.dummyAna)
2 changes: 1 addition & 1 deletion DataFormats/L1Trigger/src/VertexWord.cc
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,4 @@ namespace l1t {
}
}

} // namespace l1t
} // namespace l1t
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ Reason for dump: Requested by user
00000070 : 99d62e9a 00000187 44410444 00000010 | human readable swapped : 00000187 99d62e9a 00000010 44410444 : 00000070
00000080 : 99b0cc96 00000187 01fe7fff 07fe7fff | human readable swapped : 00000187 99b0cc96 07fe7fff 01fe7fff : 00000080
00000090 : 468de7e5 00000000 d41e0000 a0000014 | human readable swapped : 00000000 468de7e5 a0000014 d41e0000 : 00000090
================ END OF DUMP ===================
================ END OF DUMP ===================
2 changes: 1 addition & 1 deletion DataFormats/Portable/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,4 +155,4 @@ collections share a same layout. The scripts are called as follows:
./DataFormats/Portable/scripts/portableDeviceCollectionHints portabletest::TestHostMultiCollection3
```
The layouts should not be added as parameters for the device collection. Those script can be use equally with the
single layout collections or multi layout collections.
single layout collections or multi layout collections.
2 changes: 1 addition & 1 deletion DataFormats/Portable/interface/PortableCollectionCommon.h
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,4 @@ namespace portablecollection {

} // namespace portablecollection

#endif // DataFormats_Portable_interface_PortableCollectionCommon_h
#endif // DataFormats_Portable_interface_PortableCollectionCommon_h
2 changes: 1 addition & 1 deletion DataFormats/Portable/interface/PortableDeviceCollection.h
Original file line number Diff line number Diff line change
Expand Up @@ -287,4 +287,4 @@ class PortableDeviceMultiCollection {
Implementation impl_; // (serialized: this is where the layouts live)
};

#endif // DataFormats_Portable_interface_PortableDeviceCollection_h
#endif // DataFormats_Portable_interface_PortableDeviceCollection_h
2 changes: 1 addition & 1 deletion DataFormats/Portable/interface/PortableObject.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ namespace cms::alpakatools {
};
} // namespace cms::alpakatools

#endif // DataFormats_Portable_interface_PortableObject_h
#endif // DataFormats_Portable_interface_PortableObject_h
2 changes: 1 addition & 1 deletion DataFormats/Portable/interface/alpaka/PortableObject.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {

} // namespace ALPAKA_ACCELERATOR_NAMESPACE

#endif // DataFormats_Portable_interface_alpaka_PortableObject_h
#endif // DataFormats_Portable_interface_alpaka_PortableObject_h
2 changes: 1 addition & 1 deletion DataFormats/Portable/scripts/portableDeviceCollectionHints
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ print(" they are not persistent. -->")
print(" <class name=\"alpaka_rocm_async::%s\" persistent=\"false\"/>" % collectionName)
print(" <class name=\"edm::DeviceProduct<alpaka_rocm_async::%s>\" persistent=\"false\"/>" % collectionName)
print(" <class name=\"edm::Wrapper<edm::DeviceProduct<alpaka_rocm_async::%s>>\" persistent=\"false\"/>" % collectionName)
print("<lcgdict/>\n")
print("<lcgdict/>\n")
2 changes: 1 addition & 1 deletion DataFormats/PortableTestObjects/src/classes_def.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,4 @@
<class name="portabletest::TestHostMultiCollection3"/>

<class name="edm::Wrapper<portabletest::TestHostMultiCollection3>" splitLevel="0"/>
</lcgdict>
</lcgdict>
2 changes: 1 addition & 1 deletion DataFormats/SiPixelClusterSoA/src/classes.cc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "DataFormats/Portable/interface/PortableHostCollectionReadRules.h"
#include "DataFormats/SiPixelClusterSoA/interface/SiPixelClustersSoA.h"

SET_PORTABLEHOSTCOLLECTION_READ_RULES(PortableHostCollection<SiPixelClustersSoA>);
SET_PORTABLEHOSTCOLLECTION_READ_RULES(PortableHostCollection<SiPixelClustersSoA>);
2 changes: 1 addition & 1 deletion DataFormats/SoATemplate/test/SoAUnitTests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,4 @@ TEST_CASE("SoATemplate") {
t += tx;
}
}
}
}
2 changes: 1 addition & 1 deletion DataFormats/TestObjects/src/DeleteEarly.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@
// user include files
#include "DataFormats/TestObjects/interface/DeleteEarly.h"

unsigned int edmtest::DeleteEarly::s_nDeletes = 0;
unsigned int edmtest::DeleteEarly::s_nDeletes = 0;
2 changes: 1 addition & 1 deletion DataFormats/TrackingRecHitSoA/src/classes.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@

SET_PORTABLEHOSTCOLLECTION_READ_RULES(PortableHostCollection<TrackingRecHitLayout<pixelTopology::Phase1>>);
SET_PORTABLEHOSTCOLLECTION_READ_RULES(PortableHostCollection<TrackingRecHitLayout<pixelTopology::Phase2>>);
SET_PORTABLEHOSTCOLLECTION_READ_RULES(PortableHostCollection<TrackingRecHitLayout<pixelTopology::HIonPhase1>>);
SET_PORTABLEHOSTCOLLECTION_READ_RULES(PortableHostCollection<TrackingRecHitLayout<pixelTopology::HIonPhase1>>);