Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused constants in CondCore/EcalPlugins/plugins/Ecal*_PayloadInspector.cc #45096

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Remove unused constants in CondCore/EcalPlugins/plugins/Ecal*_PayloadInspector.cc #45096

merged 1 commit into from
Jun 3, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

See title

PR validation:

Bot tests

@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_CLANG_X

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone May 30, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented May 30, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45096/40430

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • CondCore/EcalPlugins (db)

@consuegs, @perrotta, @francescobrivio, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @wang0jin, @thomreis, @rsreds, @mmusich, @ReyerBand, @PonIlya, @yuanchao, @JanChyczynski this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36f475/39624/summary.html
COMMIT: fc515e6
CMSSW: CMSSW_14_1_CLANG_X_2024-05-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45096/39624/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36f475/39624/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36f475/39624/git-merge-result

Comparison Summary

Summary:

  • You potentially added 14352 lines to the logs
  • Reco comparison results: 30347 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 38000
  • DQMHistoTests: Total nulls: 154
  • DQMHistoTests: Total successes: 3300688
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.026999999999999993 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 140.043 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): 0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.051 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 4 / 46 workflows

@Dr15Jones Dr15Jones mentioned this pull request May 30, 2024
Merged
@iarspider
Copy link
Contributor Author

please test for CMSSW_14_1_X with #45110

@iarspider
Copy link
Contributor Author

@Dr15Jones thanks!

@iarspider
Copy link
Contributor Author

please test with #45110 for CMSSW_14_1_X

@iarspider
Copy link
Contributor Author

please abort

@iarspider
Copy link
Contributor Author

please test with #45110 for CMSSW_14_1_CLANG_X

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36f475/39647/summary.html
COMMIT: fc515e6
CMSSW: CMSSW_14_1_X_2024-05-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45096/39647/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 4.534.53_RunPhoton2012B/step2_RunPhoton2012B.log
  • 7.37.3_CosmicsSPLoose2018/step1_CosmicsSPLoose2018.log
  • 8.08.0_BeamHalo/step1_BeamHalo.log
Expand to see more relval errors ...

RelVals-INPUT

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36f475/39648/summary.html
COMMIT: fc515e6
CMSSW: CMSSW_14_1_CLANG_X_2024-05-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45096/39648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1000.0 step 2
1001.0 step 2
101.0 step 1
10224.0 step 1
11634.0 step 1
12434.0 step 1
12834.0 step 1
12834.7 step 1
12846.0 step 1
13034.0 step 1
1306.0 step 1
13234.0 step 1
1330.0 step 1
135.4 step 1
136.731 step 2
136.7611 step 2
136.793 step 2
136.8311 step 2
136.874 step 2
136.88811 step 2
139.001 step 2
140.023 step 2
140.043 step 2
140.063 step 2
140.56 step 2
14034.0 step 1
141.042 step 2
141.044 step 2
141.046 step 2
14234.0 step 1
158.01 step 2
23234.0 step 1
24834.0 step 1
24834.911 step 1
24896.0 step 1
24900.0 step 1
25.0 step 1
2500.4 step 2
250202.181 step 1
25034.999 step 1
25202.0 step 1
312.0 step 1
4.22 step 2
4.53 step 2
5.1 step 1
7.3 step 1
8.0 step 1
9.0 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 19407 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 66 log files, 0 edm output root files, 1 DQM output files

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36f475/39650/summary.html
COMMIT: fc515e6
CMSSW: CMSSW_14_1_X_2024-05-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45096/39650/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1000.0 step 2
1001.0 step 2
101.0 step 1
10224.0 step 1
11634.0 step 1
12434.0 step 1
12834.0 step 1
12834.7 step 1
12846.0 step 1
13034.0 step 1
1306.0 step 1
13234.0 step 1
1330.0 step 1
135.4 step 1
136.731 step 2
136.7611 step 2
136.793 step 2
136.8311 step 2
136.874 step 2
136.88811 step 2
139.001 step 2
140.023 step 2
140.043 step 2
140.063 step 2
140.56 step 2
14034.0 step 1
141.042 step 2
141.044 step 2
141.046 step 2
14234.0 step 1
158.01 step 2
23234.0 step 1
24834.0 step 1
24834.911 step 1
24896.0 step 1
24900.0 step 1
25.0 step 1
2500.4 step 2
250202.181 step 1
25034.999 step 1
25202.0 step 1
312.0 step 1
4.22 step 2
4.53 step 2
5.1 step 1
7.3 step 1
8.0 step 1
9.0 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 19179 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 66 log files, 0 edm output root files, 1 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jun 1, 2024

+db

  • Unused, indeed

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 262958e into cms-sw:master Jun 3, 2024
17 checks passed
This was referenced Jun 4, 2024
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved db-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
5 participants
@iarspider @cmsbuild @smuzaffar @perrotta @rappoccio