Fix deprecated enum arithmetics in ElectronConversionRejectionValidator and PhotonValidator #45129

iarspider · 2024-06-04T08:47:27Z

PR description:

Fixes the following warnings:

src/Validation/RecoEgamma/plugins/ElectronConversionRejectionValidator.cc: In member function 'virtual void ElectronConversionRejectionValidator::bookHistograms(dqm::legacy::DQMStore::IBooker&, const edm::Run&, const edm::EventSetup&)':
  src/Validation/RecoEgamma/plugins/ElectronConversionRejectionValidator.cc:135:105: warning: arithmetic between enumeration type 'reco::TrackBase::TrackAlgorithm' and floating-point type 'double' is deprecated [-Wdeprecated-enum-float-conversion]
   135 |       "convLeadTrackAlgo", "# of Electrons", reco::TrackBase::algoSize, -0.5, reco::TrackBase::algoSize - 0.5);
      |                                                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
  src/Validation/RecoEgamma/plugins/ElectronConversionRejectionValidator.cc:137:105: warning: arithmetic between enumeration type 'reco::TrackBase::TrackAlgorithm' and floating-point type 'double' is deprecated [-Wdeprecated-enum-float-conversion]
   137 |       "convLeadTrackAlgo", "# of Electrons", reco::TrackBase::algoSize, -0.5, reco::TrackBase::algoSize - 0.5);
      |                                                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
(...)
src/Validation/RecoEgamma/plugins/PhotonValidator.cc: In member function 'virtual void PhotonValidator::bookHistograms(dqm::legacy::DQMStore::IBooker&, const edm::Run&, const edm::EventSetup&)':
  src/Validation/RecoEgamma/plugins/PhotonValidator.cc:3130:113: warning: arithmetic between enumeration type 'reco::TrackBase::TrackAlgorithm' and floating-point type 'double' is deprecated [-Wdeprecated-enum-float-conversion]
  3130 |       iBooker.book1D("allTrackAlgo", " Track Algo ", reco::TrackBase::algoSize, -0.5, reco::TrackBase::algoSize - 0.5);
      |

PR validation:

Bot tests

iarspider · 2024-06-04T08:47:38Z

please test for CMSSW_14_1_CPP20_X

cmsbuild · 2024-06-04T08:47:48Z

cms-bot internal usage

cmsbuild · 2024-06-04T08:52:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45129/40466

This PR adds an extra 52KB to repository

cmsbuild · 2024-06-04T08:52:56Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

Validation/RecoEgamma (dqm)

@antoniovagnerini, @tjavaid, @syuvivida, @rvenditti, @nothingface0 can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

iarspider · 2024-06-04T12:25:44Z

please test

cmsbuild · 2024-06-04T14:56:13Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e785e/39681/summary.html
COMMIT: edd0f60
CMSSW: CMSSW_14_1_CPP20_X_2024-06-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45129/39681/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e785e/39681/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e785e/39681/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoPPSLocalNewT2 had ERRORS

Comparison Summary

Summary:

You potentially added 2431 lines to the logs
Reco comparison results: 123 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338862
DQMHistoTests: Total failures: 905
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3337937
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-06-04T15:15:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e785e/39690/summary.html
COMMIT: edd0f60
CMSSW: CMSSW_14_1_X_2024-06-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45129/39690/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338862
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338839
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

iarspider · 2024-06-04T21:50:38Z

please test

cmsbuild · 2024-06-05T00:33:10Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e785e/39704/summary.html
COMMIT: edd0f60
CMSSW: CMSSW_14_1_X_2024-06-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45129/39704/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338862
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338842
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

iarspider · 2024-06-11T13:33:45Z

@cms-sw/dqm-l2 gentle ping

tjavaid · 2024-06-13T03:02:40Z

please test

cmsbuild · 2024-06-13T08:25:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e785e/39862/summary.html
COMMIT: edd0f60
CMSSW: CMSSW_14_1_X_2024-06-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45129/39862/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345018
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3344992
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

iarspider · 2024-06-18T08:39:40Z

@cms-sw/dqm-l2 ping

tjavaid · 2024-06-18T09:33:23Z

+1

cmsbuild · 2024-06-18T09:33:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-06-20T22:42:19Z

+1

Fix deprecated enum arithmetics in ElectronConversionRejectionValidator

edd0f60

cmsbuild added this to the CMSSW_14_1_X milestone Jun 4, 2024

cmsbuild added dqm-pending pending-signatures orp-pending tests-started code-checks-pending labels Jun 4, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 4, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 4, 2024

cmsbuild added tests-started and removed tests-approved labels Jun 4, 2024

cmsbuild added tests-approved and removed tests-started labels Jun 5, 2024

cmsbuild added tests-started and removed tests-approved labels Jun 13, 2024

cmsbuild removed the tests-started label Jun 13, 2024

cmsbuild added the tests-approved label Jun 13, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 18, 2024

cmsbuild added orp-approved and removed orp-pending labels Jun 20, 2024

cmsbuild merged commit d7c3a57 into cms-sw:master Jun 20, 2024
16 of 17 checks passed

iarspider deleted the iarspider-patch-20240604-1 branch June 21, 2024 07:08

cmsbuild mentioned this pull request Jun 21, 2024

Heterogeneous Workflow (CLUE) in Phase2 HLT Simplified Menu #45178

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix deprecated enum arithmetics in ElectronConversionRejectionValidator and PhotonValidator #45129

Fix deprecated enum arithmetics in ElectronConversionRejectionValidator and PhotonValidator #45129

iarspider commented Jun 4, 2024

iarspider commented Jun 4, 2024

cmsbuild commented Jun 4, 2024 •

edited

Loading

cmsbuild commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

iarspider commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

iarspider commented Jun 4, 2024

cmsbuild commented Jun 5, 2024

iarspider commented Jun 11, 2024

tjavaid commented Jun 13, 2024

cmsbuild commented Jun 13, 2024

iarspider commented Jun 18, 2024

tjavaid commented Jun 18, 2024

cmsbuild commented Jun 18, 2024

antoniovilela commented Jun 20, 2024

Fix deprecated enum arithmetics in ElectronConversionRejectionValidator and PhotonValidator #45129

Fix deprecated enum arithmetics in ElectronConversionRejectionValidator and PhotonValidator #45129

Conversation

iarspider commented Jun 4, 2024

PR description:

PR validation:

iarspider commented Jun 4, 2024

cmsbuild commented Jun 4, 2024 • edited Loading

cmsbuild commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

iarspider commented Jun 4, 2024

cmsbuild commented Jun 4, 2024

Unit Tests

Comparison Summary

cmsbuild commented Jun 4, 2024

Comparison Summary

iarspider commented Jun 4, 2024

cmsbuild commented Jun 5, 2024

Comparison Summary

iarspider commented Jun 11, 2024

tjavaid commented Jun 13, 2024

cmsbuild commented Jun 13, 2024

Comparison Summary

iarspider commented Jun 18, 2024

tjavaid commented Jun 18, 2024

cmsbuild commented Jun 18, 2024

antoniovilela commented Jun 20, 2024

cmsbuild commented Jun 4, 2024 •

edited

Loading