Update the egamma regression for 2023 UPC PbPb rereco and the corresponding GTs in autoCond #46562

stahlleiton · 2024-10-31T04:32:53Z

PR description:

This PR updates the egamma regression for 2023 UPC PbPb rereco through the use of the Run3_2023_UPC era.

Also the data and HI MC Gts are updated in autoCond to take the new regressions into account:

New run3_data GT:
- 141X_dataRun3_v4 (see here the diff wrt previous 140X_dataRun3_v17)
New phase1_2023_realistic_hi GT:
- 141X_mcRun3_2023_realistic_HI_v4 (see here the diff wrt previous 141X_mcRun3_2023_realistic_HI_v3)

@mandrenguyen

PR validation:

Tested with relvals 180,180.1,181,181.1,141.901,142.901,142.903

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport plan for 14_1_X meant for the 2023 UPC PbPb rereco.

cmsbuild · 2024-10-31T04:33:13Z

cms-bot internal usage

cmsbuild · 2024-10-31T04:35:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46562/42444

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoEcal/EgammaClusterProducers/python/particleFlowSuperClusterECAL_cfi.py modified in PR(s): Zero-padding optimization for DeepSC inference #40934

cmsbuild · 2024-10-31T04:35:46Z

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

RecoEcal/EgammaClusterProducers (reconstruction)
RecoEgamma/EgammaElectronProducers (reconstruction)
RecoEgamma/EgammaTools (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@Prasant1993, @ReyerBand, @Sam-Harper, @a-kapoor, @afiqaize, @argiro, @jainshilpi, @lgray, @missirol, @ram1123, @rchatter, @rovere, @sameasy, @sobhatta, @thomreis, @valsdav, @varuns23, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2024-10-31T12:15:42Z

please test

cmsbuild · 2024-10-31T15:17:56Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a39ad/42512/summary.html
COMMIT: 0aa2b12
CMSSW: CMSSW_14_2_X_2024-10-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46562/42512/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

RelVals

5.15.1_TTbarFS/step1_TTbarFS.log
4.534.53_RunPhoton2012B/step3_RunPhoton2012B.log
4.224.22_RunCosmics2011A/step3_RunCosmics2011A.log

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
2024.0000012024.000001_RunJetMET02024D_10k/step1_dasquery.log
2024.0010012024.001001_RunZeroBias2024D_10k/step1_dasquery.log

Expand to see more relval errors ...

2024.100001
2024.101001
134.0
1000.0
144.6
1001.0
141.901
1002.0
142.901
1003.0
142.903
1010.0
2024.000001
2024.001001
2024.100001
2024.101001

AddOn Tests

fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 7 sec (ended on Thu Oct 31 14:50:10 2024) - exit: 256

fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 6 sec (ended on Thu Oct 31 14:50:12 2024) - exit: 256

pat1

----- Begin Fatal Exception 31-Oct-2024 14:50:16 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named /data/cmsbld/jenkins/workspace/ib-run-pr-addon/CMSSW_14_2_X_2024-10-30-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py
Exception Message:
 unknown python problem occurred.
TypeError: eleRegs does not already exist, so it can only be set to a CMS python configuration type

At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(319): __raiseBadSetAttr
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Mixins.py(771): _modifyParametersFromDict
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Types.py(1063): clone
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46562/42512/CMSSW_14_2_X_2024-10-30-2300/src/RecoEgamma/EgammaElectronProducers/python/lowPtGsfElectrons_cfi.py(43): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46562/42512/CMSSW_14_2_X_2024-10-30-2300/src/PhysicsTools/PatAlgos/python/producersLayer1/lowPtElectronProducer_cff.py(69): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46562/42512/CMSSW_14_2_X_2024-10-30-2300/src/PhysicsTools/PatAlgos/python/producersLayer1/patCandidates_cff.py(4): <module>
  <frozen importlib._bootstrap>(228): _call_with_frames_removed
  <frozen importlib._bootstrap_external>(850): exec_module
  <frozen importlib._bootstrap>(695): _load_unlocked
  <frozen importlib._bootstrap>(986): _find_and_load_unlocked
  <frozen importlib._bootstrap>(1007): _find_and_load
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02861/el8_amd64_gcc12/cms/cmssw/CMSSW_14_2_X_2024-10-30-2300/src/FWCore/ParameterSet/python/Config.py(762): load
  /data/cmsbld/jenkins/workspace/ib-run-pr-addon/CMSSW_14_2_X_2024-10-30-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py(11): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

cmsbuild · 2024-11-01T03:55:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46562/42466

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoEcal/EgammaClusterProducers/python/particleFlowSuperClusterECAL_cfi.py modified in PR(s): Zero-padding optimization for DeepSC inference #40934

cmsbuild · 2024-11-01T03:56:00Z

Pull request #46562 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

cmsbuild · 2024-11-15T20:28:19Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a39ad/42885/summary.html
COMMIT: 7f2d1dc
CMSSW: CMSSW_14_2_X_2024-11-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46562/42885/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially added 35 lines to the logs
Reco comparison results: 2298 differences found in the comparisons
DQMHistoTests: Total files compared: 56
DQMHistoTests: Total histograms compared: 4109127
DQMHistoTests: Total failures: 6519
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 4102584
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.094 KiB( 55 files compared)
DQMHistoSizes: changed ( 141.901 ): -0.094 KiB JetMET/SUSYDQM
Checked 241 log files, 201 edm output root files, 56 DQM output files
TriggerResults: no differences found

perrotta · 2024-11-16T08:42:31Z

@stahlleiton for documentation purposes, could you please (here and in the backport PR)

Modify the title of the PR as "Update the egamma regression for 2023 UPC PbPb rereco and the corresponding GTs in autoCond"
add the lines here below to the PR description:

Also the data and HI MC Gts are updated in autoCond to take the new regressions into account:
- New run3_data GT:
  - [141X_dataRun3_v4](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/141X_dataRun3_v4) (see [here](https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_dataRun3_v7/141X_dataRun3_v4) the diff wrt previous 140X_dataRun3_v17)
- New phase1_2023_realistic_hi GT:
  - [141X_mcRun3_2023_realistic_HI_v4](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/141X_mcRun3_2023_realistic_HI_v4) (see [here](https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/141X_mcRun3_2023_realistic_HI_v3/141X_mcRun3_2023_realistic_HI_v4) the diff wrt previous 141X_mcRun3_2023_realistic_HI_v3)

perrotta · 2024-11-16T08:42:37Z

+alca

stahlleiton · 2024-11-16T10:28:31Z

@stahlleiton for documentation purposes, could you please (here and in the backport PR)

* Modify the title of the PR as "Update the egamma regression for 2023 UPC PbPb rereco and the corresponding GTs in autoCond"

* add the lines here below to the PR description:

Also the data and HI MC Gts are updated in autoCond to take the new regressions into account:
- New run3_data GT:
  - [141X_dataRun3_v4](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/141X_dataRun3_v4) (see [here](https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_dataRun3_v7/141X_dataRun3_v4) the diff wrt previous 140X_dataRun3_v17)
- New phase1_2023_realistic_hi GT:
  - [141X_mcRun3_2023_realistic_HI_v4](https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/141X_mcRun3_2023_realistic_HI_v4) (see [here](https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/141X_mcRun3_2023_realistic_HI_v3/141X_mcRun3_2023_realistic_HI_v4) the diff wrt previous 141X_mcRun3_2023_realistic_HI_v3)

@perrotta : done, the PR title and description has been updated.

jfernan2 · 2024-11-18T09:13:57Z

+1

AdrianoDee · 2024-11-18T09:16:16Z

+pdmv

stahlleiton · 2024-11-18T20:48:19Z

@cms-sw/upgrade-l2 : please review/sign this PR , thanks

Moanwar · 2024-11-18T23:37:58Z

+Upgrade

cmsbuild · 2024-11-18T23:38:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-11-19T07:09:45Z

+1

cmsbuild added this to the CMSSW_14_2_X milestone Oct 31, 2024

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending labels Oct 31, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 31, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 31, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 31, 2024

stahlleiton force-pushed the EGReg_UPC_14_2_X branch from 0aa2b12 to b531812 Compare November 1, 2024 03:52

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Nov 1, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 1, 2024

stahlleiton mentioned this pull request Nov 1, 2024

[14_1_X] Update the egamma regression for UPC PbPb #46576

Closed

stahlleiton changed the title ~~Update the egamma regression for UPC PbPb~~ Update the egamma regression for 2023 UPC PbPb rereco Nov 2, 2024

stahlleiton force-pushed the EGReg_UPC_14_2_X branch from b531812 to 2258ac8 Compare November 2, 2024 18:11

cmsbuild removed the code-checks-approved label Nov 2, 2024

cmsbuild added tests-started and removed tests-pending labels Nov 15, 2024

cmsbuild added tests-approved and removed tests-started labels Nov 15, 2024

cmsbuild added alca-approved and removed alca-pending labels Nov 16, 2024

stahlleiton changed the title ~~Update the egamma regression for 2023 UPC PbPb rereco~~ Update the egamma regression for 2023 UPC PbPb rereco and the corresponding GTs in autoCond Nov 16, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Nov 18, 2024

cmsbuild added pdmv-approved and removed pdmv-pending labels Nov 18, 2024

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Nov 18, 2024

cmsbuild added orp-approved and removed orp-pending labels Nov 19, 2024

cmsbuild merged commit 3685722 into cms-sw:master Nov 19, 2024
11 checks passed

stahlleiton deleted the EGReg_UPC_14_2_X branch November 19, 2024 07:29

cmsbuild mentioned this pull request Nov 19, 2024

[core] Fix early return in AutoloadLibraryGenerator cms-sw/root#213

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the egamma regression for 2023 UPC PbPb rereco and the corresponding GTs in autoCond #46562

Update the egamma regression for 2023 UPC PbPb rereco and the corresponding GTs in autoCond #46562

stahlleiton commented Oct 31, 2024 •

edited

Loading

cmsbuild commented Oct 31, 2024 •

edited

Loading

cmsbuild commented Oct 31, 2024

cmsbuild commented Oct 31, 2024

jfernan2 commented Oct 31, 2024

cmsbuild commented Oct 31, 2024

cmsbuild commented Nov 1, 2024

cmsbuild commented Nov 1, 2024

cmsbuild commented Nov 15, 2024

perrotta commented Nov 16, 2024

perrotta commented Nov 16, 2024

stahlleiton commented Nov 16, 2024

jfernan2 commented Nov 18, 2024

AdrianoDee commented Nov 18, 2024

stahlleiton commented Nov 18, 2024

Moanwar commented Nov 18, 2024

cmsbuild commented Nov 18, 2024

mandrenguyen commented Nov 19, 2024

Update the egamma regression for 2023 UPC PbPb rereco and the corresponding GTs in autoCond #46562

Update the egamma regression for 2023 UPC PbPb rereco and the corresponding GTs in autoCond #46562

Conversation

stahlleiton commented Oct 31, 2024 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Oct 31, 2024 • edited Loading

cmsbuild commented Oct 31, 2024

cmsbuild commented Oct 31, 2024

jfernan2 commented Oct 31, 2024

cmsbuild commented Oct 31, 2024

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

cmsbuild commented Nov 1, 2024

cmsbuild commented Nov 1, 2024

cmsbuild commented Nov 15, 2024

Comparison Summary

perrotta commented Nov 16, 2024

perrotta commented Nov 16, 2024

stahlleiton commented Nov 16, 2024

jfernan2 commented Nov 18, 2024

AdrianoDee commented Nov 18, 2024

stahlleiton commented Nov 18, 2024

Moanwar commented Nov 18, 2024

cmsbuild commented Nov 18, 2024

mandrenguyen commented Nov 19, 2024

stahlleiton commented Oct 31, 2024 •

edited

Loading

cmsbuild commented Oct 31, 2024 •

edited

Loading