Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix early return in AutoloadLibraryGenerator #213

Closed
wants to merge 2 commits into from
Closed

[core] Fix early return in AutoloadLibraryGenerator #213

wants to merge 2 commits into from

Conversation

smuzaffar
Copy link

@hahnjo
[core] Fix early return in AutoloadLibraryGenerator
0cfb6c9 
Fixes commit e601bf8 ("[core] Reduce symbol search only to when
autoloading is enabled.").
@hahnjo
[core] Remove check from AutoloadLibraryMU
a14c665 
This implements my request from the original PR review that autoloading
should only be checked in AutoloadLibraryGenerator but that the MU must
provide the symbols it promised. This wasn't working because the early
return was broken (fixed in the previous commit).
@smuzaffar
Copy link
Author

please test for CMSSW_14_2_ROOT6_X

@cmsbuild
Copy link

A new Pull Request was created by @smuzaffar for branch cms/master/b2da3719ab.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link

cmsbuild commented Nov 18, 2024 •
edited
Loading

cms-bot internal usage

@smuzaffar smuzaffar mentioned this pull request Nov 18, 2024
Merged
@smuzaffar smuzaffar changed the base branch from cms/master/b2da3719ab to cms/master/cfc9d8d30c November 18, 2024 11:07
@smuzaffar
Copy link
Author

please test for CMSSW_14_2_ROOT6_X

@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a96e7/42931/summary.html
COMMIT: a14c665
CMSSW: CMSSW_14_2_ROOT6_X_2024-11-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/213/42931/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Author

please test for CMSSW_14_2_ROOT6_X

re-run using latest root6 IB

@smuzaffar
Copy link
Author

please test for CMSSW_14_2_ROOT6_X/el8_aarch64_gcc12

@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a96e7/42944/summary.html
COMMIT: a14c665
CMSSW: CMSSW_14_2_ROOT6_X_2024-11-18-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/213/42944/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a96e7/42944/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a96e7/42944/git-merge-result

@cmsbuild
Copy link

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a96e7/42943/summary.html
COMMIT: a14c665
CMSSW: CMSSW_14_2_ROOT6_X_2024-11-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/213/42943/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
2023.002001 step 1
2024.000001 step 1
2024.101001 step 1
2024.202001 step 1
2024.303001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 25 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1129 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 2921459
  • DQMHistoTests: Total failures: 7015
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2914424
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
  • Checked 182 log files, 152 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@hahnjo hahnjo deleted the cling-autoload branch November 27, 2024 07:46
@smuzaffar smuzaffar closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smuzaffar @cmsbuild @hahnjo