[14_1] Fix memory leak issues in Calo Layer 1 UCT Infrastructure

[aloeliger]

backport of #46543

PR description:

Taken from previous PR

This PR should handle some of the worst offending pointer issues and memory leak problems in #46526. This swaps a lot of Calo Layer 1 Infrastructure pointers over to std::shared_ptr's to try and avoid memory leak issues. Summary card regions are now stored as the objects themselves, instead of pointers to them (That decision may not be directly necessary? It makes sense to me, and there is a spot where pointers to these things are used internally, and nullptrs are possible but checked against)

This is just a first pass, but a larger fix of all of this infrastructure with smart pointers should be considered.

@mmusich @mandrenguyen FYI

PR validation:

All code compiles and has had code formatting applied. Bot tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport to 14_1 of #46543 for purposes of PbPb prompt reconstruction fixes

[cmsbuild]

A new Pull Request was created by @aloeliger for CMSSW_14_1_X.

It involves the following packages:

• L1Trigger/L1TCaloLayer1 (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix memory leak issues in Calo Layer 1 UCT Infrastructure #46543

[cmsbuild]

cms-bot internal usage

[mmusich]

type bug-fix

[mmusich]

urgent

[aloeliger]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e6cd4/42511/summary.html
COMMIT: 9b9f206
CMSSW: CMSSW_14_1_X_2024-10-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46567/42511/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3565669
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3565647
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 199 log files, 169 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

• just waiting for the main PR to finish up

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1