Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Backports of 46543 and 46451 to fix memory leak #46903

Closed
wants to merge 1 commit into from

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Dec 9, 2024

PR description:

Try to fix memory leak issue, mentionedin #46901, for ReReco 2024 with CMSSW_14_0.

Backports of

PR validation:

  • CMSSW with this PR can run.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

A new Pull Request was created by @srimanob for CMSSW_14_0_X.

It involves the following packages:

  • DQM/BeamMonitor (db, dqm)
  • L1Trigger/L1TCaloLayer1 (l1)

@aloeliger, @antoniovagnerini, @atpathak, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @perrotta, @rseidita can you please review it and eventually sign? Thanks.
@JanChyczynski, @Martin-Grunewald, @PonIlya, @francescobrivio, @missirol, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

cms-bot internal usage

@srimanob srimanob changed the title Backports of 46543 and 46451 to fix memory leak [14_0_X] Backports of 46543 and 46451 to fix memory leak Dec 9, 2024
@srimanob
Copy link
Contributor Author

srimanob commented Dec 9, 2024

@cmsbuild please test

@srimanob
Copy link
Contributor Author

srimanob commented Dec 9, 2024

This is an effort to handle #46901

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd0061/43340/summary.html
COMMIT: e4453ac
CMSSW: CMSSW_14_0_X_2024-12-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46903/43340/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+dqm

@perrotta
Copy link
Contributor

+db

@srimanob
Copy link
Contributor Author

Kindly ping @cms-sw/l1-l2 in case we need to build the new release for reprocessing. Thanks.

@srimanob
Copy link
Contributor Author

@cms-sw/orp-l2 Could you please consider this backport? We will need a new release for ReReco.

FYI @vlimant @malbouis

@srimanob
Copy link
Contributor Author

The comparison between with and without this PR can be found at #46901 (comment)

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

@srimanob should we consider backporting to intermediate releases?

@srimanob
Copy link
Contributor Author

srimanob commented Dec 16, 2024

@srimanob should we consider backporting to intermediate releases?

Hi Matt, Do you mean 14_1? Yes, I can do it. Thx.
I first need it for 14_0 used for ReReco.

@mandrenguyen
Copy link
Contributor

@srimanob should we consider backporting to intermediate releases?

Hi Matt, Do you mean 14_1? Yes, I can do it. Thx. I first need it for 14_0 used for ReReco.

Yes, please make the PRs to the intermediate release(s) and then we'll merge this.

@srimanob
Copy link
Contributor Author

Hi @mandrenguyen
Both backport PRs were merged in 14_1:
#46465 ([14.1.X] make AlcaBeamMonitor hoard less memory)
#46567 ([14_1] Fix memory leak issues in Calo Layer 1 UCT Infrastructure)

@mandrenguyen
Copy link
Contributor

backport of #46451

@mandrenguyen
Copy link
Contributor

+1

@mandrenguyen
Copy link
Contributor

merge

@iarspider
Copy link
Contributor

@srimanob could you please resolve conflicts? Thanks!

@srimanob
Copy link
Contributor Author

Hi @iarspider
How do show which conflicts? I just see the warning shows up.

@smuzaffar
Copy link
Contributor

Looks like some issue with github itself. PR has been merged. Let me close this

@smuzaffar smuzaffar closed this Dec 17, 2024
@smuzaffar
Copy link
Contributor

bot can see that this has been merged. It is visible as merged in IB page https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_14_0_X

mmusich pushed a commit to cms-trackeralign/cmssw that referenced this pull request Dec 20, 2024
[14_0_X] Backports of 46543 and 46451 to fix memory leak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants