[mkFit] small fix in propToPlane

[leonardogiannini]

PR description:

The PR is mostly due to abnormal results in the track parameters seen when running mkFit standalone and testing the propagation to plane instead the current propagation to R/Z.

The check "(std::abs(sl[n]) > std::abs(s[n]))" is removed as it misused the straight line approximation in cases where the path to the module would be shorter. The replacement is kept only to prevent numerical instability.

The rest of the code changes are minor changes.

PR validation:

As expected no change is observed in phase1 (as propToR is not used)
http://uaf-10.t2.ucsd.edu/~legianni/plots_validateP2P_sl/plots_phase1/

In phase2 the propToR is used only in the hit search, but not the fit of the parameters (which also refitted using CKF), so the final effect is very small.
http://uaf-10.t2.ucsd.edu/~legianni/plots_validateP2P_sl/plots_tt/

A small increase in n. of hits in the muon sample at high pT (e.g. http://uaf-10.t2.ucsd.edu/~legianni/plots_validateP2P_sl/plots_3_mu_pt1to1000_eta0p0to0p4)

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46906/42954

[cmsbuild]

A new Pull Request was created by @leonardogiannini for master.

It involves the following packages:

• RecoTracker/MkFitCore (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @makortel, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a8f4d/43353/summary.html
COMMIT: a158f81
CMSSW: CMSSW_15_0_X_2024-12-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46906/43353/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 284 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3623082
• DQMHistoTests: Total failures: 2451
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3620611
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 206 log files, 177 edm output root files, 47 DQM output files
• TriggerResults: found differences in 1 / 45 workflows

[jfernan2]

type bug-fix

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1