Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all well known actions #154

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Conversation

glours
Copy link
Contributor

@glours glours commented Oct 28, 2019

Rename Status action to io.cnab.status instead of status
Remove Downgrade action

I added all well known actions inside a well_know.go file (and removestatus.go), define all action name as defined in the specifications and implement all the run functions by using the run-custom action

Fix #153

@msftclas
Copy link

msftclas commented Oct 28, 2019

CLA assistant check
All CLA requirements met.

@radu-matei
Copy link
Member

/brig run

action/well_known.go Outdated Show resolved Hide resolved
action/well_known.go Outdated Show resolved Hide resolved
@radu-matei
Copy link
Member

@glours - apologies for the delay here..
Would you mind rebasing this PR? If not, I'm happy to continue the work on this branch.

@glours glours force-pushed the add_well_known_actions branch from a71d74c to 6608c1c Compare February 26, 2020 10:36
@glours
Copy link
Contributor Author

glours commented Feb 26, 2020

@radu-matei done, the PR will need a another rebase due to test issues on claim status (fix available #185 )

@glours glours force-pushed the add_well_known_actions branch from 6608c1c to 51dacac Compare February 26, 2020 12:55
@glours
Copy link
Contributor Author

glours commented Feb 26, 2020

Updated with the merge of #185 into master

@silvin-lubecki
Copy link
Contributor

/brig run

@glours glours force-pushed the add_well_known_actions branch from 51dacac to 6ced3ae Compare February 26, 2020 16:32
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits but otherwise LGTM, thank you @glours ! 👍

Rename Status action to io.cnab.status
Remove Downgrade action

Signed-off-by: Guillaume Lours <[email protected]>
@glours glours force-pushed the add_well_known_actions branch from 6ced3ae to d653049 Compare February 26, 2020 16:36
@silvin-lubecki
Copy link
Contributor

/brig run

Copy link
Member

@radu-matei radu-matei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work and for rebasing this!
LGTM

@radu-matei radu-matei merged commit eb444ef into cnabio:master Feb 26, 2020
@glours glours deleted the add_well_known_actions branch February 27, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

action.Status doesn't follow the v1.0.0 spec
6 participants