-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all well known actions #154
Conversation
/brig run |
@glours - apologies for the delay here.. |
a71d74c
to
6608c1c
Compare
@radu-matei done, the PR will need a another rebase due to test issues on claim status (fix available #185 ) |
6608c1c
to
51dacac
Compare
Updated with the merge of #185 into master |
/brig run |
51dacac
to
6ced3ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits but otherwise LGTM, thank you @glours ! 👍
Rename Status action to io.cnab.status Remove Downgrade action Signed-off-by: Guillaume Lours <[email protected]>
6ced3ae
to
d653049
Compare
/brig run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work and for rebasing this!
LGTM
Rename Status action to
io.cnab.status
instead ofstatus
Remove Downgrade action
I added all well known actions inside a
well_know.go
file (and removestatus.go
), define all action name as defined in the specifications and implement all the run functions by using therun-custom
actionFix #153