Change underway to pending #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdice
approved these changes
Feb 25, 2020
|
The claims marshaling test seems to be failing: |
vdice
reviewed
Feb 25, 2020
radu-matei
approved these changes
Feb 25, 2020
vdice
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Arggh sorry about the merge conflict @technosophos ... too antsy to merge the other PR 😅 . LGTM once resolved.
Signed-off-by: Matt Butcher <[email protected]>
Signed-off-by: Matt Butcher <[email protected]>
Signed-off-by: Matt Butcher <[email protected]>
technosophos
force-pushed
the
fix/claims-pending
branch
from
1b0411e to
02f6fba
Compare
This was referenced Feb 26, 2020
carolynvs
pushed a commit
to carolynvs/cnab-go
that referenced
this pull request
May 21, 2020
* Initial Docker client for driver * Update to use HOME dir, docker attach * Lint fix * Update contaienr attach handling * Added docker socket * Updated to use Docker's CopyToContainer * Lint fixes * Hardcoded isTerm to false, refactored tar build * Updated docker client creation * Removed commented import * Formatting fix Co-authored-by: Jeremy Rickard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses cnabio/cnab-spec#334 for the Go library, changing
underwaytopending.Signed-off-by: Matt Butcher [email protected]