feat(claim.go): add Outputs field to Claim struct #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vdice
commented
Jul 19, 2019
vdice
commented
- add Outputs field to Claim struct, per cnab-spec (updated in Add outputs to claim spec cnab-spec#217)
vdice
force-pushed
the
feat/add-claim-outputs
branch
from
153a818 to
395b85a
Compare
carolynvs
reviewed
Jul 22, 2019
claim/claimstore_test.go
Outdated
| "foo-output": true, | ||
| "bar-output": "bar", | ||
| } | ||
| is.Equal(c.Outputs, want, "Wrong outputs on claim") |
There was a problem hiding this comment.
The signature for Equal is first the expected result, then the actual result. This got switched here which can lead to confusing error messages if the test were to fail.
claim/claimstore_test.go
Outdated
| "foo-output": true, | ||
| "bar-output": "baz", | ||
| } | ||
| is.Equal(c.Outputs, want, "Wrong outputs on claim") |
There was a problem hiding this comment.
Same here, the parameter order should be reversed.
vdice
force-pushed
the
feat/add-claim-outputs
branch
from
395b85a to
33b7052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.