-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add outputs to claim spec #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, we probably should have added this with the original outputs PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Also in support of this. Thanks!
- Add outputs to example and description of example in 400-claims - Add example of outputs in 400-claims - Alphabetize list of outputs in 400-claims - Add outputs in claims schema Signed-off-by: Ryan Moran <[email protected]> Signed-off-by: Urvashi Reddy <[email protected]>
8936182
to
f7d958c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new example, LGTM.
We wanted to wait for Jeremy to approve the example, but since he's out on PTO this week I'm gonna go ahead and merge this with the two approvals we have now. |
This PR adds outputs to the claim spec to allow adding outputs to Duffle.
cnabio/duffle#747
cc @ryanmoran @jeremyrickard @carolynvs @simonferquel