Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outputs to claim spec #217

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Conversation

astrieanna
Copy link
Contributor

This PR adds outputs to the claim spec to allow adding outputs to Duffle.

cnabio/duffle#747

cc @ryanmoran @jeremyrickard @carolynvs @simonferquel

jeremyrickard
jeremyrickard previously approved these changes Jul 10, 2019
Copy link
Member

@jeremyrickard jeremyrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, we probably should have added this with the original outputs PR.

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Also in support of this. Thanks!

400-claims.md Outdated Show resolved Hide resolved
@jeremyrickard jeremyrickard dismissed their stale review July 15, 2019 16:17

Waiting for updated example

- Add outputs to example and description of example in 400-claims
- Add example of outputs in 400-claims
- Alphabetize list of outputs in 400-claims
- Add outputs in claims schema

Signed-off-by: Ryan Moran <[email protected]>
Signed-off-by: Urvashi Reddy <[email protected]>
Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new example, LGTM.

@youreddy
Copy link

We wanted to wait for Jeremy to approve the example, but since he's out on PTO this week I'm gonna go ahead and merge this with the two approvals we have now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants