-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings and initial contents for Korean localization #291
Conversation
I hope to note that there is no Netlify preview for this branch ( |
@seokho-son, just to clarify, this is to create the Korean branch and that's why you need one of us to approve as well, correct? |
I created Korean branch https://github.com/cncf/glossary/tree/dev-ko already. This PR is not about creating a new branch but is to config Korean language to enable Korean option to the glossary website. The configuration will be effective only in I assume this kind of PR is the first PR that each localization team open firstly.
Each localization team needs to modify config.toml for a new language configuration according to https://github.com/cncf/glossary/blob/main/LOCALIZATION.md#add-a-new-language-setting-to-site-configuration Even though the target branch of this PR is [FYI] I added Korean approvers for files in |
Ok, since you would like a maintainer to review for correctness, let's wait for Jason to come back next week as I can only really review and approve content, not setups. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good but obviously I don't understand Korean. I'm not sure why the _index.md files are in English but I'm happy to trust your judgement.
@JasonMorgan Thanks :) In case of content/ko/_index.md, the contents in the file is Korean. |
This PR is to initiate Korean localization based on
Base and target branch of this PR is
dev-ko
which is development branch for Korean localization.This PR includes
[languages.ko]
section inconfig.toml
Since Korean localization team owns
content/ko/*
only,this PR will require approvals from upstream owners (maintainers).