Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings & Initial content for Hindi Localisation #300

Merged
merged 14 commits into from
Feb 3, 2022

Conversation

anubha-v-ardhan
Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan commented Jan 9, 2022

This PR adds HIndi localization's initial setup and tests the settings

@netlify
Copy link

netlify bot commented Jan 9, 2022

✔️ Deploy Preview for cncfglossary ready!

🔨 Explore the source changes: e686242

🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/61da84a1f12f82000a7b8bf9

😎 Browse the preview: https://deploy-preview-300--cncfglossary.netlify.app

@seokho-son seokho-son added the hold Wait, please do not proceed this yet label Jan 9, 2022
@seokho-son
Copy link
Collaborator

@anubha-v-ardhan
I think contents of this PR need to be applied to dev-hi branch (which will be created soon) and not to main branch.
Let me guide through the issue for Initiate Hindi Localization Team #297 .

@anubha-v-ardhan
Copy link
Contributor Author

anubha-v-ardhan commented Jan 9, 2022

@seokho-son Yep! I'll change the base branch once dev-hi is available :)
Let's keep this on hold till then

@anubha-v-ardhan
Copy link
Contributor Author

Hey @seokho-son I believe we can now unhold this

@anubha-v-ardhan anubha-v-ardhan changed the base branch from main to dev-hi January 21, 2022 15:47
@jihoon-seo jihoon-seo added the lang/hi for Hindi label Jan 25, 2022
@seokho-son
Copy link
Collaborator

@anubha-v-ardhan
Thank you for the contribution !! :)
According to the updated localization guide, we prefer contents for tasks for 3-1 ~ 3-4 are in one PR.
It is to make sure this task: 3-5. Check configuration works and open a PR

As you know, there are separated PRs for Hindi localization setting.
#300
#349

Could you make contents in two PRs into one like #291 example ?

In that PR, we'd like to request screenshot like this
#291 (comment)

@anubha-v-ardhan
Copy link
Contributor Author

Sure @seokho-son I'll add everything to this PR and request to close #349

@anubha-v-ardhan anubha-v-ardhan changed the title Update config.toml to with settings for HIndi localization Settings & Intiate content for Hindi Localisation Jan 29, 2022
@anubha-v-ardhan anubha-v-ardhan changed the title Settings & Intiate content for Hindi Localisation Settings & Initial content for Hindi Localisation Jan 30, 2022
config.toml Show resolved Hide resolved
content/hi/_TEMPLATE.md Show resolved Hide resolved
@anubha-v-ardhan
Copy link
Contributor Author

anubha-v-ardhan commented Feb 2, 2022

@seokho-son everything is on one PR now and build works perfectly :)

Screenshot from 2022-02-02 17-26-24

@seokho-son seokho-son removed the hold Wait, please do not proceed this yet label Feb 2, 2022
Copy link
Collaborator

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@CathPag CathPag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CathPag
CathPag approved these changes Feb 3, 2022
Copy link
Collaborator

@Garima-Negi Garima-Negi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anubha-v-ardhan anubha-v-ardhan merged commit 708ca22 into cncf:dev-hi Feb 3, 2022
@anubha-v-ardhan anubha-v-ardhan deleted the anubha-v-ardhan-patch-2 branch February 4, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/hi for Hindi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants