-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings & Initial content for Hindi Localisation #300
Settings & Initial content for Hindi Localisation #300
Conversation
✔️ Deploy Preview for cncfglossary ready! 🔨 Explore the source changes: e686242 🔍 Inspect the deploy log: https://app.netlify.com/sites/cncfglossary/deploys/61da84a1f12f82000a7b8bf9 😎 Browse the preview: https://deploy-preview-300--cncfglossary.netlify.app |
@anubha-v-ardhan |
@seokho-son Yep! I'll change the base branch once |
Hey @seokho-son I believe we can now unhold this |
@anubha-v-ardhan As you know, there are separated PRs for Hindi localization setting. Could you make contents in two PRs into one like #291 example ? In that PR, we'd like to request screenshot like this |
Sure @seokho-son I'll add everything to this PR and request to close #349 |
@seokho-son everything is on one PR now and build works perfectly :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anubha-v-ardhan Thank you for the build test :)
I checked following tasks are complete. (target branch is dev-hi)
- 3-1. Adding a new language setting to site configuration https://github.com/cncf/glossary/blob/main/LOCALIZATION.md#3-1-adding-a-new-language-setting-to-site-configuration
- 3-2. Adding a file for site strings https://github.com/cncf/glossary/blob/main/LOCALIZATION.md#3-2-adding-a-file-for-site-strings
- 3-3. Adding a new localization directory https://github.com/cncf/glossary/blob/main/LOCALIZATION.md#3-3-adding-a-new-localization-directory
- 3-4. Minimum required content https://github.com/cncf/glossary/blob/main/LOCALIZATION.md#3-4-minimum-required-content
- 3-5. Check configuration works and open a PR https://github.com/cncf/glossary/blob/main/LOCALIZATION.md#3-5-check-configuration-works-and-open-a-pr
@CathPag @JasonMorgan This PR looks good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds HIndi localization's initial setup and tests the settings