Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: panic in redirectOnOrAcquireLease due to finished trace #25575

Closed
mberhault opened this issue May 16, 2018 · 1 comment
Closed

core: panic in redirectOnOrAcquireLease due to finished trace #25575

mberhault opened this issue May 16, 2018 · 1 comment
Assignees
@a-robinson
Labels
C-test-failure Broken test (automatically or manually discovered).

Comments

@mberhault
Copy link
Contributor

mberhault commented May 16, 2018 •
edited
Loading

This panic was caught 10 times by sentry overnight. This is coming from 22aa780#diff-f053cdaf591941e579feecd64a66ab07R1582 just added.

This panic usually indicates that Finish has been called on the trace, but further logging is requested.

Sentry issue: COCKROACHDB-G7

*log.safeError: stopper.go:176: runtime.errorString: runtime error: index out of range
  File "github.com/cockroachdb/cockroach/pkg/util/tracing/tracer_span.go", line 358, in LogFields
  File "github.com/cockroachdb/cockroach/pkg/util/log/trace.go", line 131, in eventInternal
  File "github.com/cockroachdb/cockroach/pkg/util/log/trace.go", line 178, in vEventf
  File "github.com/cockroachdb/cockroach/pkg/util/log/trace.go", line 193, in VEventf
  File "github.com/cockroachdb/cockroach/pkg/storage/replica.go", line 1414, in func1
...
(8 additional frame(s) were not displayed)

stopper.go:176: runtime.errorString: runtime error: index out of range
@mberhault
Copy link
Contributor Author

Sentry issue: COCKROACHDB-G8

@mberhault mberhault added the C-test-failure Broken test (automatically or manually discovered). label May 16, 2018
a-robinson added a commit to a-robinson/cockroach that referenced this issue May 16, 2018
@a-robinson
storage: fix use of context with closed trace
248b38e 
Fixes cockroachdb#25575

Release note: None
@a-robinson a-robinson mentioned this issue May 16, 2018
Merged
craig bot pushed a commit that referenced this issue May 16, 2018
@a-robinson
Merge #24945 #25581
3deb9d1 
24945: server: exempt healthcheck endpoint from authentication check r=couchand a=vilterp

Otherwise, you get the red "connection lost" banner until you log in.

This will have no effect until the auth mux is put on the request path (#24944).

Fixes #24942 

25581: storage: fix use of context with closed trace r=a-robinson a=a-robinson

Fixes #25575

Release note: None

Co-authored-by: Pete Vilter <[email protected]>
Co-authored-by: Alex Robinson <[email protected]>
@craig craig bot closed this as completed in #25581 May 16, 2018
@mvijaykarthik mvijaykarthik mentioned this issue Sep 25, 2018
Merged
mvijaykarthik pushed a commit to mvijaykarthik/cockroach that referenced this issue Sep 25, 2018
@a-robinson
backport-2.0: storage: fix use of context with closed trace
29436bb 
Backport 1/1 commits from cockroachdb#25581

---

Fixes cockroachdb#25575

Release note: None
craig bot pushed a commit that referenced this issue Sep 25, 2018
@a-robinson
Merge #30614
6940ef5 
30614: backport-2.0: storage: fix use of context with closed trace r=tschottdorf a=mvijaykarthik

Backport 1/1 commits from #25581

---

Fixes #25575

Release note: None

Co-authored-by: Alex Robinson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-robinson a-robinson

Labels
C-test-failure Broken test (automatically or manually discovered).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mberhault @a-robinson