server: exempt healthcheck endpoint from authentication check #24945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
This is not the correct way to do this. In s.mux.Handle(statusPrefix, authHandler)
s.mux.Handle(authPrefix, gwMux)adminPrefix currently goes to authHandler, but add this line: s.mux.Handle("/_admin/v1/health", gwMux)And it will bypass the auth handler for just that one endpoint. Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
6 tasks
vilterp
force-pushed
the
exempt-healthcheck
branch
from
3c2e183 to
4d14bf3
Compare
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
|
bors r+ |
Build failed (retrying...) |
|
bors r+ |
Build failed (retrying...) |
|
This isn’t a flake - breaks some assertion. Wasn’t able to figure it out
before I left. Sorry, should have given you a heads up.
…On Tue, May 15, 2018 at 3:11 PM craig[bot] ***@***.***> wrote:
Build failed (retrying...)
- GitHub CI (Cockroach)
<https://teamcity.cockroachdb.com/viewLog.html?buildId=659987&buildTypeId=Cockroach_UnitTests>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#24945 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAcreAbcQu__DSLnxc3_nmY3a1vkCruks5ty0SFgaJpZM4TcmrI>
.
|
couchand
force-pushed
the
exempt-healthcheck
branch
from
4d14bf3 to
7c2d6f4
Compare
|
Rebased off of #25195 and updated TestHealthAPI to reflect the change. |
Fixes cockroachdb#24942 Release note: None
couchand
force-pushed
the
exempt-healthcheck
branch
from
7c2d6f4 to
f0eab2e
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 16, 2018
24945: server: exempt healthcheck endpoint from authentication check r=couchand a=vilterp Otherwise, you get the red "connection lost" banner until you log in. This will have no effect until the auth mux is put on the request path (#24944). Fixes #24942 25581: storage: fix use of context with closed trace r=a-robinson a=a-robinson Fixes #25575 Release note: None Co-authored-by: Pete Vilter <[email protected]> Co-authored-by: Alex Robinson <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, you get the red "connection lost" banner until you log in.
This will have no effect until the auth mux is put on the request path (#24944).
Fixes #24942