Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: simplify grpcConfusedErrConnClosedByPeer #49359

Closed
tbg opened this issue May 21, 2020 · 0 comments · Fixed by #49366
Closed

cli: simplify grpcConfusedErrConnClosedByPeer #49359

tbg opened this issue May 21, 2020 · 0 comments · Fixed by #49366
Assignees
@knz
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@tbg
Copy link
Member

tbg commented May 21, 2020

According to #49114 (comment), we should be able to remove

cockroach/pkg/cli/quit.go

Line 288 in a8ae1bf

case s.Code() == codes.Unimplemented && strings.Contains(err.Error(), "Decompressor is not installed"):

because we have since picked up grpc/grpc-go#3054.
@tbg tbg added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. A-cli labels May 21, 2020
@tbg tbg assigned knz May 21, 2020
@tbg tbg mentioned this issue May 21, 2020
Merged
This was referenced May 21, 2020
Merged
Merged
Merged
Merged
Merged
craig bot pushed a commit that referenced this issue May 21, 2020
@knz
Merge #49362
436a82a 
49362: cli/quit: proceed with hard shutdown even with short --drain-wait r=tbg a=knz

Found while investigating #49359.
:facepalm: on my side for not testing this.
Also :zap: on grpc for cooking their own error protocol that's incompatible with Go's.

Release note (bug fix): When the value passed to `--drain-wait` is
very small, but non-zero, `cockroach quit` in certain cases would
not proceed to perform a hard shutdown. This has been corrected.
This bug existed since v19.1.9, v19.2.7 and v20.1.1.

Co-authored-by: Raphael 'kena' Poss <[email protected]>
@craig craig bot closed this as completed in 0857bf6 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knz knz

Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cli/quit: clean up some now-unneeded code knz/cockroach
2 participants
@knz @tbg