cli/quit: clean up some now-unneeded code #49366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since gRPC has been updated, some error handling code was not any more needed. Release note: None
|
This change is |
tbg
approved these changes
May 26, 2020
| @@ -270,24 +267,3 @@ func getAdminClient(ctx context.Context, cfg server.Config) (serverpb.AdminClien | |||
| } | |||
| return serverpb.NewAdminClient(conn), finish, nil | |||
| } | |||
|
|
|||
| // grpcConfusedErrConnClosedByPeer returns true if the given error | |||
There was a problem hiding this comment.
If this were still needed, how would we find out?
There was a problem hiding this comment.
TestDockerCLI will start to flake again.
|
bors r=tbg |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49359
Since gRPC has been updated, some error handling code was not any more
needed.
Release note: None