build: upgrade to go1.16.5 #66404
Assignees
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-dev-inf
Comments
petermattis
added
the
C-enhancement
|
Filed cockroachdb/pebble#1166 to add CI for Pebble |
rail
added a commit
to rail/cockroach
that referenced
this issue
Jun 18, 2021
Fixes cockroachdb#66404 * Upgrade gazelle to latest version. Go 1.16 updates `go.sum` when gazelle calls `go download`. The new version fixes this issue. See bazel-contrib/bazel-gazelle#1015. * Remove line references in `build/README.md`, because they are not stable. * Set `GOPATH` in various places for bazel based builds and tests in order to work round the case when `go env` fails when `GOPATH` and `HOME` are unset. See golang/go#43938 for the details. * Set `GO111MODULE=off` in `pkg/acceptance/compose/gss/psql/Dockerfile`. Go 1.16 requires `go.mod` in order to build and test the module without `GO111MODULE=off`. Checklist: * [x] Adjust the Pebble tests to run in new version. * [x] Adjust version in Docker image ([source](./builder/Dockerfile)). * [X] Rebuild and push the Docker image (following [Basic Process](#basic-process)) * [x] Bump the version in `WORKSPACE` under `go_register_toolchains`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). * [X] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)). * [x] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release. * [x] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed. * [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)). * [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). * [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects. * [ ] Adjust `GO_VERSION` in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) and ask the Developer Infrastructure team to deploy new images. Release note: None
craig bot
pushed a commit
that referenced
this issue
Jun 23, 2021
66505: build: update go to 1.16.5 r=rickystewart a=rail Fixes #66404 * Upgrade gazelle to latest version. Go 1.16 updates `go.sum` when gazelle calls `go download`. The new version fixes this issue. See bazel-contrib/bazel-gazelle#1015. * Remove line references in `build/README.md`, because they are not stable. * Set `GOPATH` in various places for bazel based builds and tests in order to work round the case when `go env` fails when `GOPATH` and `HOME` are unset. See golang/go#43938 for the details. * Set `GO111MODULE=off` in `pkg/acceptance/compose/gss/psql/Dockerfile`. Go 1.16 requires `go.mod` in order to build and test the module without `GO111MODULE=off`. Checklist: * [x] Adjust the Pebble tests to run in new version. * [x] Adjust version in Docker image ([source](./builder/Dockerfile)). * [x] Adjust version in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) * [x] Rebuild and push the Docker image (following [Basic Process](#basic-process)) * [x] Bump the version in `WORKSPACE` under `go_register_toolchains`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). * [x] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)). * [x] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release. * [x] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed. * [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)). * [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). * [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects. * [ ] Ask the Developer Infrastructure team to deploy new TeamCity agent images according to [packer/README.md](./packer/README.md) Release note: None Co-authored-by: Rail Aliiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Go1.16 was released on Feb 16. We should upgrade from go1.15 to go1.16 before we get much farther in the 21.2 development cycle so that any problems can be discovered and addressed.
The text was updated successfully, but these errors were encountered: