build: update go to 1.16.5 #66505
Merged
build: update go to 1.16.5 #66505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rail
force-pushed
the
golang1.16
branch
14 times, most recently
from
100cfaf to
788c0d0
Compare
|
congrats! always a doozy. bazel made it worse haha |
I'm totally fine with this, given how it improves reproducibility. \o/ |
rickystewart
requested changes
Jun 21, 2021
rickystewart
approved these changes
Jun 22, 2021
|
bors r=rickystewart |
|
Build failed: |
|
Flaky tests!!! |
Fixes cockroachdb#66404 * Upgrade gazelle to latest version. Go 1.16 updates `go.sum` when gazelle calls `go download`. The new version fixes this issue. See bazel-contrib/bazel-gazelle#1015. * Remove line references in `build/README.md`, because they are not stable. * Set `GOPATH` in various places for bazel based builds and tests in order to work round the case when `go env` fails when `GOPATH` and `HOME` are unset. See golang/go#43938 for the details. * Set `GO111MODULE=off` in `pkg/acceptance/compose/gss/psql/Dockerfile`. Go 1.16 requires `go.mod` in order to build and test the module without `GO111MODULE=off`. Checklist: * [x] Adjust the Pebble tests to run in new version. * [x] Adjust version in Docker image ([source](./builder/Dockerfile)). * [x] Adjust version in the TeamCity agent image ([setup script](./packer/teamcity-agent.sh)) * [x] Rebuild and push the Docker image (following [Basic Process](#basic-process)) * [x] Bump the version in `WORKSPACE` under `go_register_toolchains`. You may need to bump [rules_go](https://github.com/bazelbuild/rules_go/releases). * [x] Bump the version in `builder.sh` accordingly ([source](./builder.sh#L6)). * [x] Bump the version in `go-version-check.sh` ([source](./go-version-check.sh)), unless bumping to a new patch release. * [x] Bump the go version in `go.mod`. You may also need to rerun `make vendor_rebuild` if vendoring has changed. * [x] Bump the default installed version of Go in `bootstrap-debian.sh` ([source](./bootstrap/bootstrap-debian.sh)). * [x] Replace other mentions of the older version of go (grep for `golang:<old_version>` and `go<old_version>`). * [ ] Update the `builder.dockerImage` parameter in the TeamCity [`Cockroach`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Cockroach&tab=projectParams) and [`Internal`](https://teamcity.cockroachdb.com/admin/editProject.html?projectId=Internal&tab=projectParams) projects. * [ ] Ask the Developer Infrastructure team to deploy new TeamCity agent images according to [packer/README.md](./packer/README.md) Release note: None
|
bors r=rickystewart |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66404
go.sumwhengazelle calls
go download. The new version fixes this issue. Seelanguage/go: don't let 'go mod download' edit go.sum bazel-contrib/bazel-gazelle#1015.
build/README.md, because they are notstable.
GOPATHin various places for bazel based builds and tests inorder to work round the case when
go envfails whenGOPATHandHOMEare unset. See build: spurious missing $GOPATH error golang/go#43938 forthe details.
GO111MODULE=offinpkg/acceptance/compose/gss/psql/Dockerfile.Go 1.16 requires
go.modin order to build and test the modulewithout
GO111MODULE=off.Checklist:
WORKSPACEundergo_register_toolchains. You may need to bump rules_go.builder.shaccordingly (source).go-version-check.sh(source), unless bumping to a new patch release.go.mod. You may also need to rerunmake vendor_rebuildif vendoring has changed.bootstrap-debian.sh(source).golang:<old_version>andgo<old_version>).builder.dockerImageparameter in the TeamCityCockroachandInternalprojects.Release note: None