Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of deprecated Chainlink function latestAnswer #178

Closed
code423n4 opened this issue Feb 2, 2022 · 1 comment
Closed

Use of deprecated Chainlink function latestAnswer #178

code423n4 opened this issue Feb 2, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2022-01-notional/blob/d171cad9e86e0d02e0909eb66d4c24ab6ea6b982/contracts/utils/EIP1271Wallet.sol#L175-L177

According to Chainlink's documentation, the latestAnswer function is deprecated. This function does not revert if no answer has been reached but returns 0, causing an incorrect price fed to the EIP1271Wallet.

See: code-423n4/2021-07-wildcredit-findings#75
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Feb 2, 2022
code423n4 added a commit that referenced this issue Feb 2, 2022
@code423n4
WatchPug issue #178
54da9c9
This was referenced Feb 6, 2022
Closed
Open
@jeffywu jeffywu added duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") labels Feb 6, 2022
This was referenced Feb 6, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@jeffywu jeffywu removed the duplicate This issue or pull request already exists label Feb 8, 2022
@pauliax
Copy link
Collaborator

pauliax commented Feb 12, 2022

A duplicate of #197

@pauliax pauliax closed this as completed Feb 12, 2022
@pauliax pauliax added the duplicate This issue or pull request already exists label Feb 12, 2022
weitianjie2000 added a commit to notional-finance/staked-note that referenced this issue Feb 15, 2022
@weitianjie2000
Use of deprecated Chainlink function latestAnswer [code-423n4/2022-01…
930d202 
…-notional-findings#178]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffywu @pauliax @code423n4