Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chainlink.latestRoundData() might return incorrect result. #108

Closed
code423n4 opened this issue Jun 15, 2022 · 3 comments
Closed

Chainlink.latestRoundData() might return incorrect result. #108

code423n4 opened this issue Jun 15, 2022 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-06-connext/blob/main/contracts/contracts/core/connext/helpers/ConnextPriceOracle.sol#L125

Vulnerability details

Impact

Chainlink.latestRoundData() might return incorrect result.

Proof of Concept

You can find the same issue(M-05) here.
https://code4rena.com/reports/2022-04-backd

Tools Used

Manual Review

Recommended Mitigation Steps

You can modify L125 like below.

(uint80 roundID, int256 answer, , , uint80 answeredInRound) = aggregator.latestRoundData();
if (answeredInRound < roundID) {
	return 0;
}
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Jun 15, 2022
code423n4 added a commit that referenced this issue Jun 15, 2022
@code423n4
auditor0517 issue #108
75a13a2
@ecmendenhall
Copy link

Duplicate of #190

@jakekidd jakekidd added the duplicate This issue or pull request already exists label Jun 24, 2022
@jakekidd
Copy link
Collaborator

dup #190

@0xleastwood
Copy link
Collaborator

Merging with #208.

@0xleastwood 0xleastwood added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax and removed 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ecmendenhall @jakekidd @0xleastwood @code423n4