Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA Report #208

Open
code423n4 opened this issue Jun 19, 2022 · 1 comment
Open

QA Report #208

code423n4 opened this issue Jun 19, 2022 · 1 comment
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Low Risk Issues

  • Wrong implementation of PortalFacet.getAavePortalFeeDebt().
    contracts\core\connext\facets\PortalFacet.sol#L38-L40

  • Different validations of adminFee and swapFee.
    contracts\core\connext\helpers\StableSwap.sol#L97-98
    contracts\core\connext\libraries\SwapUtils.sol#L1071
    contracts\core\connext\libraries\SwapUtils.sol#L1084

  • Recommend to use safeIncreaseAllowance(), safeDecreaseAllowance() as safeApprove() is deprecated.
    contracts\core\connext\libraries\AssetLogic.sol#L347

  • Wrong comments
    contracts\core\connext\helpers\StableSwap.sol#L223
    contracts\core\connext\helpers\StableSwap.sol#L227
    contracts\core\connext\helpers\StableSwap.sol#L240
    contracts\core\connext\libraries\SwapUtils.sol#L790
    contracts\core\connext\libraries\LibConnextStorage.sol#L299
@code423n4 code423n4 added bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax labels Jun 19, 2022
code423n4 added a commit that referenced this issue Jun 19, 2022
@code423n4
auditor0517 issue #208
01775cc
@jakekidd
Copy link
Collaborator

jakekidd commented Jul 2, 2022

  • Needs more details, how is implementation "wrong"?
  • Invalid: Looking at SwapUtils, this seems correct... adminFee should take a portion of swapFee, they are not the same.
  • approval needs to be reset to 0 and then increased, so we are stuck using safeApprove method in order to do so
  • Again, needs more details? how are comments "wrong" exactly?

very little to work with here in comparison to other QA reports

@0xleastwood 0xleastwood mentioned this issue Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakekidd @code423n4