QA Report

[code423n4]

See the markdown file with the details of this report here.

[GalloDaSballo]

01 Require() should be used instead of assert()

R

02 Upgradeable contract is missing a gap[50] storage variable to allow for new storage variables in later versions

R

03 Missing events for functions that change critical parameters

NC

04 Open TODOS

NC

05 Include return parameters in natspec comment

NC

06 Typos

NC

07 Best practice is to prevent signature malleability

L

08 Using both named returns and a return statement isn't necessary

R

09 Non-library or interface files should use fixed compiler version, not floating ones

NC

10 Use a more recent version of solidity

NC

[GalloDaSballo]

1L 3R 6NC

[c4-judge]

GalloDaSballo marked the issue as grade-c