Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getInflationAmt() IS SUSCEPTIBLE TO DOS WITH BLOCK GAS LIMIT #634

Closed
code423n4 opened this issue Jan 3, 2023 · 4 comments
Closed

getInflationAmt() IS SUSCEPTIBLE TO DOS WITH BLOCK GAS LIMIT #634

code423n4 opened this issue Jan 3, 2023 · 4 comments
Labels
bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue duplicate-302 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-12-gogopool/blob/main/contracts/contract/RewardsPool.sol#L74

Vulnerability details

getInflationAmt() is a public function and it contains the following code:

for (uint256 i = 0; i < inflationIntervalsElapsed; i++) {

It is an unbounded loop, depending on the inflation intervals

If inflationIntervalsElapsed is big enough, the block gas limit may be hit.

Proof of Concept

https://github.com/code-423n4/2022-12-gogopool/blob/main/contracts/contract/RewardsPool.sol#L74

Recommended Mitigation Steps

Limit the max number of loop iterations to prevent hitting the block gas limit.

Reference:

https://consensys.github.io/smart-contract-best-practices/attacks/denial-of-service/#dos-with-block-gas-limit
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Jan 3, 2023
code423n4 added a commit that referenced this issue Jan 3, 2023
@code423n4
Diana issue #634
e0128c5
C4-Staff added a commit that referenced this issue Jan 6, 2023
@C4-Staff
original risk added for issue #634
2366689
@c4-judge
Copy link
Contributor

c4-judge commented Jan 8, 2023

GalloDaSballo marked the issue as duplicate of #139

@c4-judge c4-judge closed this as completed Jan 8, 2023
@c4-judge c4-judge reopened this Jan 29, 2023
@c4-judge
Copy link
Contributor

GalloDaSballo marked the issue as not a duplicate

@c4-judge c4-judge added QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax downgraded by judge Judge downgraded the risk level of this issue duplicate-302 and removed 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value labels Jan 29, 2023
@c4-judge
Copy link
Contributor

Duplicate of #302

@GalloDaSballo
Copy link

L

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working downgraded by judge Judge downgraded the risk level of this issue duplicate-302 QA (Quality Assurance) Assets are not at risk. State handling, function incorrect as to spec, issues with clarity, syntax
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @code423n4 @c4-judge