Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research PR-issue automation for CLI #142

Closed
3 of 7 tasks
matejchalk opened this issue Oct 24, 2023 · 4 comments
Closed
3 of 7 tasks

Research PR-issue automation for CLI #142

matejchalk opened this issue Oct 24, 2023 · 4 comments
Labels
🦾 CI/CD continuous integration and deployment
Milestone

Comments

@matejchalk
Copy link
Collaborator

matejchalk commented Oct 24, 2023

Use GitHub Actions (use what's in the marketplace) to automate the following:

  • when a PR is opened, author should be assigned automatically
  • when a PR changes a package (e.g. plugin-eslint), the corresponding label should be assigned
  • when a PR is linked to an issue, issue status should change to "In review"
  • when a PR is linked to an issue, all of the issue's labels should be added to the PR
  • when a PR is not linked to an issue, it should be added to Project board with "In review" status
  • when a PR title is created or changed, it should be checked with Commitlint
  • when a PR cannot be merged because of conflicts, a "has conflicts" label should be added (and removed once conflicts are resolved)
@matejchalk matejchalk added the 🦾 CI/CD continuous integration and deployment label Oct 24, 2023
@kristihoskova kristihoskova changed the title PR-issue automation for CLI Research PR-issue automation for CLI Oct 25, 2023
@kristihoskova
Copy link

We will do the simple ones and the others that needs more refinement will be separated to another issue.

@IKatsuba IKatsuba self-assigned this Nov 24, 2023
This was referenced Nov 25, 2023
@IKatsuba
Copy link
Contributor

There is a problem with the "has conflicts" label. The default pull_request workflow trigger does not work when PR has conflicts. It can do pull_request_target, but this trigger has some security notes.

The problem is more complex. We may need to prioritize this option in a separate issue.

@IKatsuba
Copy link
Contributor

Some thoughts about linked issues:

  • PR can have more than one linked issue
  • linked issues can be accessed with GraphQL API. But if I understand right, there will be ALL linked issues.
  • linked issues can be accessed with PR body parsing. We can find keywords like closes and assume it is the linked issue.

IKatsuba added a commit that referenced this issue Nov 27, 2023
Part of #142 

- [x] when a PR is opened, author should be assigned automatically
- [x] when a PR changes a package (e.g. `plugin-eslint`), the
corresponding label should be assigned
- [ ] when a PR is linked to an issue, issue status should change to "In
review"
- [ ] when a PR is linked to an issue, all of the issue's labels should
be added to the PR
- [ ] when a PR is not linked to an issue, it should be added to Project
board with "In review" status
- [x] when a PR title is created or changed, it should be checked with
Commitlint
- [ ] when a PR cannot be merged because of conflicts, a "has conflicts"
label should be added (and removed once conflicts are resolved)

Make three integrations. Another has to be done in another PR.
@vmasek vmasek modified the milestones: 2. Integration, 4. Public Mar 7, 2024
@BioPhoton
Copy link
Collaborator

@vmasek lets close it

@vmasek vmasek closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦾 CI/CD continuous integration and deployment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants