Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow for PR automation #319

Merged
merged 8 commits into from
Nov 27, 2023
Merged

ci: add workflow for PR automation #319

merged 8 commits into from
Nov 27, 2023

Conversation

IKatsuba
Copy link
Contributor

@IKatsuba IKatsuba commented Nov 25, 2023

Part of #142

  • when a PR is opened, author should be assigned automatically
  • when a PR changes a package (e.g. plugin-eslint), the corresponding label should be assigned
  • when a PR is linked to an issue, issue status should change to "In review"
  • when a PR is linked to an issue, all of the issue's labels should be added to the PR
  • when a PR is not linked to an issue, it should be added to Project board with "In review" status
  • when a PR title is created or changed, it should be checked with Commitlint
  • when a PR cannot be merged because of conflicts, a "has conflicts" label should be added (and removed once conflicts are resolved)

Make three integrations. Another has to be done in another PR.

@github-actions github-actions bot added the 🦾 CI/CD continuous integration and deployment label Nov 25, 2023
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🙂 Good idea to add the "testing" and "CI/CD" labels, too 👍

.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
.github/workflows/pr-title-commitlint-check.yml Outdated Show resolved Hide resolved
.github/workflows/pr-title-commitlint-check.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@Tlacenka Tlacenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an example PR and tried it out, nice QoL improvements! 🎉

The author self-assignment works. ✔️
The PR title commit lint also works well. ✔️
The only issue I see is the recognition of testing/production code/CI paths which were already mentioned by Matěj. 🎨

Copy link
Collaborator

@BioPhoton BioPhoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice automations!

@IKatsuba IKatsuba merged commit c1a93ed into main Nov 27, 2023
18 checks passed
@IKatsuba IKatsuba deleted the github-actions branch November 27, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦾 CI/CD continuous integration and deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants