-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 4.9.0 #5772
release: 4.9.0 #5772
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5772 +/- ##
==========================================
+ Coverage 72.66% 74.94% +2.27%
==========================================
Files 30 30
Lines 1683 1688 +5
Branches 370 371 +1
==========================================
+ Hits 1223 1265 +42
+ Misses 397 361 -36
+ Partials 63 62 -1
Continue to review full report at Codecov.
|
750ed49
to
17d4113
Compare
Terminal is not working as shared first here: #5769 (comment) Need to fix this before releasing. |
How I'm testing standalone release:
Last thing I'll do is try running the |
Tested with
Only other thing that comes to mind is creating a draft release which will build artifacts in CI, then I can download them and test those (in case something in CI is being funky). |
While testing a pre-release, there seems to be a bug with the file permissions for `product.json`. Adding `chmod +x` to see if that fixes it.
Release candidates have been tested and I've tested locally so I'm confident we can release this now. cc @code-asher |
test/unit/node/wrapper.test.ts
Outdated
@@ -0,0 +1,18 @@ | |||
import { ChildProcess } from "child_process" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to release. Added to keep code coverage from decreasing and CI ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after we export ChildProcess
.
Co-authored-by: Asher <[email protected]>
Published as a release candidate which can be installed via:
curl -fsSL https://code-server.dev/install.sh | sh -s -- --edge --standalone