Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 4.9.0 #5772

Merged
merged 25 commits into from
Dec 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
9694242
wip: changelog
jsjoeio Nov 10, 2022
17d4113
fixup
jsjoeio Nov 10, 2022
96b3c3e
Merge branch 'main' into release/v4.9.0
jsjoeio Nov 10, 2022
ccf882f
Merge branch 'main' into release/v4.9.0
jsjoeio Nov 10, 2022
9efbd2d
Merge branch 'main' into release/v4.9.0
jsjoeio Nov 30, 2022
fc4d2b5
fix: add +x to product.json in build-vscode
jsjoeio Dec 1, 2022
c9279cc
Merge branch 'main' into release/v4.9.0
jsjoeio Dec 1, 2022
130f52e
chore: increase timeout
jsjoeio Dec 1, 2022
0f66360
fix: keep product.json file permissions in release
jsjoeio Dec 2, 2022
f7db2a0
trigger ci
jsjoeio Dec 2, 2022
ace0910
chore: update package.json bust cache
jsjoeio Dec 2, 2022
2b32b10
fixup!: fix: keep product.json file permissions in release
jsjoeio Dec 2, 2022
956ed96
Revert "fix: add +x to product.json in build-vscode"
jsjoeio Dec 2, 2022
c761199
chore: pin ubuntu runner in build code-server
jsjoeio Dec 2, 2022
e701b74
chore: update prettierignore
jsjoeio Dec 2, 2022
0c7a60e
chore: add notes to changelog
jsjoeio Dec 2, 2022
40396cc
chore: use ubuntu-22.04 for e2e
jsjoeio Dec 2, 2022
60ab23f
chore: pin all jobs in build to ubuntu 20.04
jsjoeio Dec 5, 2022
292a63d
Merge branch 'main' into release/v4.9.0
jsjoeio Dec 5, 2022
73b61ec
feat(wrapper): add tests for isChild
jsjoeio Dec 5, 2022
8ed7498
fixup: include description ts-expect-error comment
jsjoeio Dec 6, 2022
a89d3e3
chore: update CHANGELOG
jsjoeio Dec 6, 2022
4a5ef4c
chore: update Helm chart
jsjoeio Dec 6, 2022
73faddd
fixup: use our childProcess
jsjoeio Dec 6, 2022
99033dd
Update CHANGELOG.md
jsjoeio Dec 6, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ concurrency:
jobs:
prettier:
name: Format with Prettier
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
timeout-minutes: 5
steps:
- name: Checkout repo
Expand All @@ -37,7 +37,7 @@ jobs:

doctoc:
name: Doctoc markdown files
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
timeout-minutes: 5
steps:
- name: Checkout repo
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:

lint-helm:
name: Lint Helm chart
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
timeout-minutes: 5
steps:
- name: Checkout repo
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:

lint-ts:
name: Lint TypeScript files
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
timeout-minutes: 5
steps:
- name: Checkout repo
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:

build:
name: Build code-server
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
timeout-minutes: 30
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
Expand Down Expand Up @@ -244,7 +244,7 @@ jobs:
# Only run if PR comes from base repo or event is not a PR
# Reason: forks cannot access secrets and this will always fail
if: github.event.pull_request.head.repo.full_name == github.repository || github.event_name != 'pull_request'
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- name: Checkout repo
uses: actions/checkout@v3
Expand Down Expand Up @@ -295,8 +295,8 @@ jobs:
test-e2e:
name: Run e2e tests
needs: build
runs-on: ubuntu-latest
timeout-minutes: 15
runs-on: ubuntu-20.04
timeout-minutes: 25
steps:
- name: Checkout repo
uses: actions/checkout@v3
Expand Down Expand Up @@ -351,7 +351,7 @@ jobs:
test-e2e-proxy:
name: Run e2e tests behind proxy
needs: build
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
timeout-minutes: 25
steps:
- name: Checkout repo
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,8 @@ jobs:
echo "Updating version in lib/vscode/product.json"
tmp=$(mktemp)
jq '.codeServerVersion = "$VERSION"' release/lib/vscode/product.json > "$tmp" && mv "$tmp" release/lib/vscode/product.json
# Ensure it has the same permissions as before
chmod 644 release/lib/vscode/product.json

- name: Compress release package
run: tar -czf package.tar.gz release
Expand Down
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
lib/vscode
lib/vscode-reh-web-linux-x64
release-standalone
release-packages
release
helm-chart
test/scripts
Expand Down
22 changes: 22 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,28 @@ Code v99.99.999

-->

## [4.9.0](https://github.com/coder/code-server/releases/tag/v4.9.0) - 2022-12-06

Code v1.73.1

### Changed

- Upgraded to Code 1.73.1

### Added

- `/security.txt` added as a route with info on our security policy information thanks to @ghuntley

### Fixed

- Installing on majaro images should now work thanks to @MrPeacockNLB for
adding the `--noconfirm` flag in `install.sh`

### Known Issues

- `--cert` on Ubuntu 22.04: OpenSSL v3 is used which breaks `pem` meaning the
`--cert` feature will not work. [Reference](https://github.com/adobe/fetch/pull/318#issuecomment-1306070259)

## [4.8.3](https://github.com/coder/code-server/releases/tag/v4.8.3) - 2022-11-07

Code v1.72.1
Expand Down
4 changes: 2 additions & 2 deletions ci/helm-chart/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 3.3.3
version: 3.4.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
appVersion: 4.8.3
appVersion: 4.9.0
2 changes: 1 addition & 1 deletion ci/helm-chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ replicaCount: 1

image:
repository: codercom/code-server
tag: '4.8.3'
tag: '4.9.0'
pullPolicy: Always

# Specifies one or more secrets to be used when pulling images from a
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@
"ide",
"coder",
"vscode-remote",
"browser-ide"
"browser-ide",
"remote-development"
],
"engines": {
"node": "16"
Expand Down
2 changes: 1 addition & 1 deletion src/node/wrapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ abstract class Process {
* Child process that will clean up after itself if the parent goes away and can
* perform a handshake with the parent and ask it to relaunch.
*/
class ChildProcess extends Process {
export class ChildProcess extends Process {
public logger = logger.named(`child:${process.pid}`)

public constructor(private readonly parentPid: number) {
Expand Down
14 changes: 14 additions & 0 deletions test/unit/node/wrapper.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { ChildProcess, ParentProcess, isChild } from "../../../src/node/wrapper"

describe("wrapper", () => {
describe("isChild", () => {
it("should return false for parent process", () => {
const p = new ParentProcess("1")
expect(isChild(p)).toBe(false)
})
})
it("should return false for parent process", () => {
const childProc = new ChildProcess(1)
expect(isChild(childProc)).toBe(true)
})
})