Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of typos fixed in LibreOffice #428

Closed
wants to merge 2 commits into from
Closed

List of typos fixed in LibreOffice #428

wants to merge 2 commits into from

Conversation

Gelma
Copy link
Contributor

@Gelma Gelma commented Apr 1, 2018

This is the list of words fixed in LibreOffice.
It's a specific list, so I guess it's better if
you check word by word.

I purged words already present in all the history
of CodeSpell dictionary (to avoid to re-insert words
removed before, for any reason).

This is the list of words fixed in LibreOffice.
It's a specific list, so I guess it's better if
you check word by word.

I purged words already present in *all* the history
of CodeSpell dictionary (to avoid to re-insert words
removed before, for any reason).
@codecov-io
Copy link

codecov-io commented Apr 1, 2018

Codecov Report

Merging #428 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files           2        2           
  Lines         665      665           
  Branches       93       93           
=======================================
  Hits          584      584           
  Misses         62       62           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be48f1f...9669566. Read the comment docs.

luzpaz added a commit to luzpaz/codespell that referenced this pull request Apr 2, 2018
Started to separate codespell-project#428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.
@luzpaz luzpaz mentioned this pull request Apr 2, 2018
luzpaz added a commit to luzpaz/codespell that referenced this pull request Apr 2, 2018
Continue to separate codespell-project#428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.
@luzpaz luzpaz mentioned this pull request Apr 2, 2018
@luzpaz
Copy link
Collaborator

luzpaz commented Apr 2, 2018

@Gelma
What's the LO license ?

@fitojb
Copy link

fitojb commented Apr 2, 2018

LibreOffice’s source code is licensed under the Mozilla Public License 2.0, with portions under the Apache License 2.0.

asynchrounous->asynchronous
asynchrounsly->asynchronously
asynschron->asynchronous
atemptively->attemptively
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a valid word

apllicatin->application
apllication->application
appedn->append
appendent->appendend
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. Should be appended.
I've removed this in #430

acessor->accessor
achor->Anchor
ACII->ASCII
Acitivate->Activate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be lowercase, fixed in #430

autocoomit->autocommit
autofilt->autofilter
autofomat->autoformat
autogrowwith->autogrowwidth
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we should add this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of specific words just for LO.

That's the reason I didn't merge directly, but let other decide about what to exclude.

bage->bag
baisc->basic
balacing->balancing
ballonmode->balloonmode
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or this...

basci->basic
basf->base
basicmanger->basicmanager
basidide->basicide
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem relevant either. basic ide ?

breakes->breaks
brfore->before
brigthness->brightness
bringtofont->bringtofront
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be kept in ?

carryintg->carrying
caseingore->caseignore
caseinlie->caseinline
case-insenstive->case-insensitive
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder why this one is hyphenated where most of the other multi-words (see directly above and below) aren't

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list if made of words found in the LO sources.

So, as I found 'em, I recorded.

cellxs->cells
centain->certain
centerd->centered
centimetres->centimeters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centimetres is a valid European spelling. We've removed and metre words from dictionary.txt because of this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny.
I parsed all the git history of CodeSpell to avoid to re-insert something already removed.

@Gelma
Copy link
Contributor Author

Gelma commented Apr 2, 2018

@luzpaz
I don't see problem for the license.

These are the typo that I manually fixed inside LO. Just words.

alloced->allocated
alloed->allowed
allowe->allowed
alls->all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be "falls"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arm-in I can add your suggestions to #430

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it's not wrong (but I understand if you don't want include for general purpose)

I found - always in LO - senteces like "alls the bullets" and so on.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in #430

alignmen->alignment
alignmnet->alignment
alising->aliasing
aliver->alive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be "liver" (for whatever reason)

alignmnet->alignment
alising->aliasing
aliver->alive
alled->called
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be "allied"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeppa, also here it was exactly a missing "c" (I repeat, this is LO specific. It makes sense to avoid it for general case)

aliver->alive
alled->called
alloced->allocated
alloed->allowed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be "allied"

contnt->content
contolls->controls
contols->controls
contorls->conrtols
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here

combind->combined
comilers->compilers
commen->comment
commens->comments
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a legit word. But obsolete AFAICT

wronf->wrong
wuold->would
xdpf->xpdf
xelementacces->xelementaccess
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not relevant, IMO

Yugoslac->Yugoslav
ziped->zipped
zlot->slot
zuser->user
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relevant?

@luzpaz
Copy link
Collaborator

luzpaz commented Apr 2, 2018

@Gelma thank you for submitting this. I acknowledge the work it took.

Couple of things, I think we're going to merge it in to the codespell dictionary.txt and therefore it needs to be submit in easily reviewable chunks. In the past I've done one letter at a time in alphabetical order. I've started on a an b already as you can see (c is currently being worked on).

@Gelma
Copy link
Contributor Author

Gelma commented Apr 2, 2018

@luzpaz
Thanks a lot for your review.

I would like you complete it. Better two more eyes.

@Gelma
Copy link
Contributor Author

Gelma commented Apr 3, 2018

@arm-in @luzpaz
Thanks a lot to both for the review.

I included in my file. Now I push a new version with also the rest of the fixes.

luzpaz added a commit to luzpaz/codespell that referenced this pull request Apr 3, 2018
Started to separate codespell-project#428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 9, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
@luzpaz luzpaz mentioned this pull request May 9, 2018
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 9, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
@luzpaz luzpaz mentioned this pull request May 9, 2018
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 9, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
larsoner pushed a commit that referenced this pull request May 10, 2018
* Letter 'i' from #436

Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Follow-up fixes

* Revised per feedback

* fixed broken entry

* More dupe fixes

* removed dupe

* remove another dupe
larsoner pushed a commit that referenced this pull request May 10, 2018
* Letter 'q' from #436

Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Update dictionary.txt
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 10, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 10, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 10, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
larsoner pushed a commit that referenced this pull request May 10, 2018
* Letter 'u' from #436

Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* removed and merged dupe

* removed another dupe

* merged and removed dupe

* Add additional suggested results
larsoner pushed a commit that referenced this pull request May 10, 2018
* Letter 'v' from #436

Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Added suggested additional result
larsoner pushed a commit that referenced this pull request May 10, 2018
* Letter ''w, x, y, and z' from #436

Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Added suggested additional entries
larsoner pushed a commit that referenced this pull request May 10, 2018
Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 10, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
larsoner pushed a commit that referenced this pull request May 10, 2018
* Letter 't' from #436

Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Removed dupe

* Removed another dupe

* Added suggestions
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 11, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 11, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. 
Note: please review closely
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 11, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
larsoner pushed a commit that referenced this pull request May 11, 2018
* Letter 'p' from #436

Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Added suggested entry results
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 11, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. 
Note: please review closely
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 11, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 14, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 14, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. 
Note: please review closely
larsoner pushed a commit that referenced this pull request May 14, 2018
* Letter 'r' from #436

Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. 
Note: please review closely

* removed dupe

* Added requested revisions
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 14, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 16, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
luzpaz added a commit to luzpaz/codespell that referenced this pull request May 17, 2018
Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Continuing to separate ~codespell-project#428~ codespell-project#436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
larsoner pushed a commit that referenced this pull request May 17, 2018
* Letter 's' from #436

Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well. Continuing to separate ~#428~ #436 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

* Added specialy->specially

* removed dupe

* removed another dupe

* Added requested revisions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants