Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter 'b' from #428 #431

Merged
merged 5 commits into from
May 4, 2018
Merged

Conversation

luzpaz
Copy link
Collaborator

@luzpaz luzpaz commented Apr 2, 2018

Continue to separate #428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.

@codecov-io
Copy link

codecov-io commented Apr 2, 2018

Codecov Report

Merging #431 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files           2        2           
  Lines         665      665           
  Branches       93       93           
=======================================
  Hits          584      584           
  Misses         62       62           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f4332f...0e4ea81. Read the comment docs.

@fitojb
Copy link

fitojb commented Apr 2, 2018

Why not commit with @Gelma’s Git identity?

@luzpaz
Copy link
Collaborator Author

luzpaz commented Apr 2, 2018

@fitojb it's not about the glory, I'm actually making it easier for the devs to inspect the enormous PR.
I've found several mistakes already and words that are non-relevant. If they are approved they can be resubmitted by @Gelma

@Gelma
Copy link
Contributor

Gelma commented Apr 2, 2018

@luzpaz
Thanks a lot for the review.
I don't need spotlight, so, do as you prefer.

I prefer if you review all the rest, split the chunk, and so on. You save me lot of time.

bufffer->buffer
bufffers->buffers
buffor->buffer
buffors->buffers
bugous->bogus
buguous->bugous
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be buguous->bogus.

banannas->bananas
bandaid->band-aid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should allow bandaid as an alternative spelling of band-aid.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm fine either way.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

bizzare->bizarre
blaim->blame
blaimed->blamed
blak->blank
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blak could also be a typo for black

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -1323,7 +1323,7 @@ baloon->balloon
baloons->balloons
balse->false
banannas->bananas
bandaid->band-aid
band-aid->bandaid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think band-aid is the better spelling, bandaid is less good. We could suggest that bandaid be changed to band-aid, or just allow it. Sorry if my previous comment was unclear.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so bandaid->band-aid, bandaid, ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just leave it, don't make any suggestion for 'bandaid'.

@larsoner
Copy link
Member

larsoner commented May 4, 2018

Sorry, needs a rebase now

luzpaz added 5 commits May 4, 2018 09:54
Continue to separate codespell-project#428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.
@luzpaz
Copy link
Collaborator Author

luzpaz commented May 4, 2018

Rebased and ready for merge

@larsoner larsoner merged commit 018d823 into codespell-project:master May 4, 2018
@luzpaz luzpaz deleted the letter-b-LO branch May 4, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants