-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Letter 'b' from #428 #431
Letter 'b' from #428 #431
Conversation
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
=======================================
Coverage 87.81% 87.81%
=======================================
Files 2 2
Lines 665 665
Branches 93 93
=======================================
Hits 584 584
Misses 62 62
Partials 19 19 Continue to review full report at Codecov.
|
@luzpaz I prefer if you review all the rest, split the chunk, and so on. You save me lot of time. |
3a3dc07
to
0788083
Compare
codespell_lib/data/dictionary.txt
Outdated
bufffer->buffer | ||
bufffers->buffers | ||
buffor->buffer | ||
buffors->buffers | ||
bugous->bogus | ||
buguous->bugous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be buguous->bogus.
codespell_lib/data/dictionary.txt
Outdated
banannas->bananas | ||
bandaid->band-aid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we should allow bandaid as an alternative spelling of band-aid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm fine either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
codespell_lib/data/dictionary.txt
Outdated
bizzare->bizarre | ||
blaim->blame | ||
blaimed->blamed | ||
blak->blank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blak could also be a typo for black
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
codespell_lib/data/dictionary.txt
Outdated
@@ -1323,7 +1323,7 @@ baloon->balloon | |||
baloons->balloons | |||
balse->false | |||
banannas->bananas | |||
bandaid->band-aid | |||
band-aid->bandaid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think band-aid is the better spelling, bandaid is less good. We could suggest that bandaid be changed to band-aid, or just allow it. Sorry if my previous comment was unclear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so bandaid->band-aid, bandaid,
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just leave it, don't make any suggestion for 'bandaid'.
Sorry, needs a rebase now |
Continue to separate codespell-project#428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.
Rebased and ready for merge |
Continue to separate #428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.