Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter 'c' from #428 #472

Merged
merged 4 commits into from
May 2, 2018
Merged

Letter 'c' from #428 #472

merged 4 commits into from
May 2, 2018

Conversation

luzpaz
Copy link
Collaborator

@luzpaz luzpaz commented Apr 27, 2018

Continue to separate #428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.

@codecov-io
Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #472 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #472   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files           2        2           
  Lines         665      665           
  Branches       93       93           
=======================================
  Hits          584      584           
  Misses         62       62           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1be4b...b6111c2. Read the comment docs.

Continue to separate codespell-project#428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.
@@ -2119,7 +2271,10 @@ compresion->compression
compresor->compressor
compresser->compressor
comprimise->compromise
compromize->compromise
compsite->composit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be compsite->composite

cartdridge->cartridge
Carthagian->Carthaginian
carthographer->cartographer
cartilege->cartilage
cartilidge->cartilage
cartrige->cartridge
cas->case
case-insenstive->case-insensitive
casesensitve->casesensitive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this should be case-sensitive

conain->contain
conained->contained
conainer->container
conainers->containers
conaining->containing
conains->contains
conainted->contained
conatain->contain
conatainer->conaitner
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be conatainer->container

contol->control
contoler->controller
contoller->controller
contollers->controllers
contolls->controls
contols->controls
contorls->conrtols
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contorls->controls

catterpilar->caterpillar
catterpilars->caterpillars
catterpillar->caterpillar
catterpillars->caterpillars
cattleship->battleship
cauched->catched
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cauched->caught

cleean->clean
cleint->client
cleints->clients
clera->clear, sclera,
clese->close
cleses->closes
clevely->cleverly
cliensite->clientside
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cliensite->client-side

commuication->communication
commuications->communications
commuinications->communications
communcation->communication
communciation->communication
communiation->communication
communites->communities
comobobox->combobox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comobobox->combo box

@luzpaz
Copy link
Collaborator Author

luzpaz commented Apr 28, 2018

Thanks for the review. Yikes, a lot 'got by the goalie'.
So here are the revisions + embellishments 1b5fb25
I also added a few more c words in 882c901

crashs->crashes
crated->created
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word crated is valid, this correction should be removed.

Copy link
Collaborator Author

@luzpaz luzpaz May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's not standard, I'll use crated->created, crated, JIC ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@luzpaz
Copy link
Collaborator Author

luzpaz commented May 2, 2018

Done. If there is nothing else, than we're ready for merge.

@larsoner larsoner merged commit 3a4047a into codespell-project:master May 2, 2018
@luzpaz luzpaz deleted the letter/c branch May 2, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants