Make docker-compose.yml configurable #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oaphi
added
type: configuration
Oaphi
force-pushed
the
0valt/compose
branch
2 times, most recently
from
b5e0fe8 to
746246c
Compare
Merged
ArtOfCode-
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor PR making docker-compose.yml configurable (while still providing an example Compose file & ensuring that it is automatically set up via the local-setup.sh script).
Rationale
While convenient, compose files can differ depending on the users' setup just as much as Dockerfile files (which we've already made configurable). This change allows for greater flexibility while maintaining a good (and tested) default in the spirit of Omakase. Not prescribing a specific Compose file is also standard practice in dockerized projects (see, for example, Pi-hole).
Important note
There is a new Docker-specific environment variable that should be set in the .env file in project root:
COMPOSE_FILE(it's a predefined environment variable). If not supplied, compose will use the default docker-compose.yml file from project root, so nothing should break for existing users.