0valt/1505/search fix #1506
Merged
0valt/1505/search fix #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oaphi
added
area: backend
…unintentional easter egg when searching for user:0
ArtOfCode-
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked by: #1504 (it's a bit too problematic to switch without breaking my setup or accidentally committing my compose file, so I opted to branch off that PR)
closes: #1505
This is how the search results page when using the
user:mequalifier while logged out will look like (not sure whether the widget should be an error or a warning - open for ideas):Note that as per discussion:
I specifically avoided implementing what's mentioned in Cellio's answer as that is out of scope of the fix, but we should definitely add the suggestion to the list of search UX improvements to work on, in my opinion.