Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we receive int exit code #45

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Make sure we receive int exit code #45

merged 1 commit into from
Mar 7, 2023

Conversation

amureki
Copy link
Collaborator

@amureki amureki commented Feb 27, 2023

  • added a missing test case for an error
  • fixed tests to not try to use non-existent files, which was leading to SystemExit(2) unrecognized arguments python
  • made strict exit_code == 1 assertion

@amureki amureki added the bug Something isn't working label Feb 27, 2023
@amureki amureki requested a review from codingjoe February 27, 2023 13:13
@amureki amureki self-assigned this Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (3d458d9) compared to base (1dfb345).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          127       127           
=========================================
  Hits           127       127           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codingjoe codingjoe merged commit 8a4491e into main Mar 7, 2023
@codingjoe codingjoe deleted the exit-code branch March 7, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants