Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we receive int exit code #45

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Make sure we receive int exit code #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/fixtures/.relint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@
hint: Get it done right away!
filePattern: ^(?!.*test_).*\.(py|js)$
error: false

- name: No fixme (warning)
pattern: '[fF][iI][xX][mM][eE]'
hint: Fix it right away!
filePattern: ^(?!.*test_).*\.(py|js)$
error: true
29 changes: 22 additions & 7 deletions tests/test_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,32 @@ def test_version(tmpdir, capsys):


class TestMain:
@pytest.mark.parametrize("filename", ["test_parse.py", "[a-b].py", "[b-a].py"])
def test_main_execution(self, filename, tmpdir, fixture_dir):
def test_main_execution(self, tmpdir, fixture_dir):
with (fixture_dir / ".relint.yml").open() as fs:
config = fs.read()
tmpdir.join(".relint.yml").write(config)
tmpdir.join("dummy.py").write("# TODO do something")
with tmpdir.as_cwd():
with pytest.raises(SystemExit) as exc_info:
main(["relint.py", filename])
main(["relint.py", "dummy.py"])

assert exc_info.value.code == 0

def test_main_execution_with_error(self, capsys, tmpdir, fixture_dir):
with (fixture_dir / ".relint.yml").open() as fs:
config = fs.read()
tmpdir.join(".relint.yml").write(config)
tmpdir.join("dummy.py").write("# FIXME do something")
with tmpdir.as_cwd():
with pytest.raises(SystemExit) as exc_info:
main(["relint.py", "dummy.py"])

expected_message = "dummy.py:1 No fixme (warning)\nHint: Fix it right away!\n1> # FIXME do something\n"

out, _ = capsys.readouterr()
assert expected_message == out
assert exc_info.value.code == 1

def test_main_execution_with_custom_template(self, capsys, tmpdir, fixture_dir):
with (fixture_dir / ".relint.yml").open() as fs:
config = fs.read()
Expand All @@ -45,16 +60,16 @@ def test_main_execution_with_custom_template(self, capsys, tmpdir, fixture_dir):
assert expected_message == out
assert exc_info.value.code == 0

@pytest.mark.parametrize("filename", ["test_parse.py", "[a-b].py", "[b-a].py"])
def test_raise_for_warnings(self, filename, tmpdir, fixture_dir):
def test_raise_for_warnings(self, tmpdir, fixture_dir):
with (fixture_dir / ".relint.yml").open() as fs:
config = fs.read()
tmpdir.join(".relint.yml").write(config)
tmpdir.join("dummy.py").write("# TODO do something")
with tmpdir.as_cwd():
with pytest.raises(SystemExit) as exc_info:
main(["relint.py", "-W", filename])
main(["relint.py", "dummy.py", "-W"])

assert exc_info.value.code != 0
assert exc_info.value.code == 1

def test_main_execution_with_diff(self, capsys, mocker, tmpdir, fixture_dir):
with (fixture_dir / ".relint.yml").open() as fs:
Expand Down