-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for actuators and remote control using PB messages #120
Merged
ecourtois
merged 8 commits into
master
from
119-add-support-for-actuators-and-remote-control-using-pb-messages
Jan 3, 2023
Merged
Add support for actuators and remote control using PB messages #120
ecourtois
merged 8 commits into
master
from
119-add-support-for-actuators-and-remote-control-using-pb-messages
Jan 3, 2023
+1,538
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cc264a
to
3eabfae
Compare
gdoffe
requested changes
Jan 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typos/comments mainly.
Good job and happy to see arms and pumps back !
To fix warnings breaking compilation using GCC 12. Remove `#include "shell_comands.h"` as in RIOT-OS/RIOT#18152 Signed-off-by: Eric Courtois <[email protected]>
UART_2 (USART3) was previously used for the LIDAR which support has been moved on Raspberry Pi4 in a previous commit. This ISR definition is a deletion oversight as UART_2 is now dedicated to LX Servomotors using UART5. Signed-off-by: Eric Courtois <[email protected]>
Signed-off-by: Eric Courtois <[email protected]>
Signed-off-by: Eric Courtois <[email protected]>
Use configuration related to robot 2022. Signed-off-by: Eric Courtois <[email protected]>
Avoid stack overflow when a warning is emitted if a thread iteration lasts too long. Signed-off-by: Eric Courtois <[email protected]>
…ssages Add C++ classes to represent servomotors and vacuum pumps. Initialize all actuators. Define PB messages to send actuators state to Copilot. Define PB messages to receive actuator commands from Copilot. Create a thread to send actuators state. Add uartpb handlers for actuator commands. Signed-off-by: Eric Courtois <[email protected]>
Signed-off-by: Eric Courtois <[email protected]>
3eabfae
to
b75b2b4
Compare
gdoffe
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add C++ classes to represent servomotors and vacuum pumps.
Initialize all actuators.
Define PB messages to send actuators state to Copilot.
Define PB messages to receive actuator commands from Copilot.
Create a thread to send actuators state.
Add uartpb handlers for actuator commands.