Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic preview method per task #6205

Open
huchenlei opened this issue Dec 24, 2024 · 6 comments
Open

Dynamic preview method per task #6205

huchenlei opened this issue Dec 24, 2024 · 6 comments
Labels
Feature A new feature to add to ComfyUI.

Comments

@huchenlei
Copy link
Collaborator

Feature Idea

Each queued task can spcify its own preview method instead of relying on a static preview method set via server launch args.

This should enables selecting preview method by adjusting frontend settings without restart the server.

Existing Solutions

https://github.com/ltdrdata/ComfyUI-Manager has a UI selection to pick preview method. However, it requires restart to take effect.

image

Other

No response

@huchenlei huchenlei added the Feature A new feature to add to ComfyUI. label Dec 24, 2024
@ltdrdata
Copy link
Collaborator

ltdrdata commented Dec 25, 2024

The preview method selection in ComfyUI-Manager is applied immediately without restarting the server.
However, it does not affect the inference currently in progress and will only apply to the next inference.

@huchenlei
Copy link
Collaborator Author

The preview method selection in ComfyUI-Manager is applied immediately without restarting the server. However, it does not affect the inference currently in progress and will only apply to the next inference.

I think this feature should be in core. Maybe you can help upstream the manager impl to core?

@ltdrdata
Copy link
Collaborator

Currently, the settings are saved in the config.ini of ComfyUI-Manager, but it seems better to move them to comfy.settings.json.

However, one thing to consider in this case is that comfy.settings.json has so far been structured to configure only the front-end information.

Since this change will involve modifying the backend settings, it would be good to allow for a callback to handle this.

@huchenlei
Copy link
Collaborator Author

Currently, the settings are saved in the config.ini of ComfyUI-Manager, but it seems better to move them to comfy.settings.json.

However, one thing to consider in this case is that comfy.settings.json has so far been structured to configure only the front-end information.

Since this change will involve modifying the backend settings, it would be good to allow for a callback to handle this.

I don't think the setting JSON file needs to be read by the backend python server, as the frontend can pass the setting value as a request param to achieve per-request dynamic adjustment.

@ltdrdata
Copy link
Collaborator

Currently, the settings are saved in the config.ini of ComfyUI-Manager, but it seems better to move them to comfy.settings.json.
However, one thing to consider in this case is that comfy.settings.json has so far been structured to configure only the front-end information.
Since this change will involve modifying the backend settings, it would be good to allow for a callback to handle this.

I don't think the setting JSON file needs to be read by the backend python server, as the frontend can pass the setting value as a request param to achieve per-request dynamic adjustment.

Then, is it sufficient to simply expose an endpoint that allows the preview method to be dynamically configured?

ltdrdata added a commit to ltdrdata/ComfyUI that referenced this issue Dec 29, 2024
* post method `/preview_method` is added

comfyanonymous#6205
@ltdrdata
Copy link
Collaborator

Once it is reflected in the front, I will remove the feature from ComfyUI-Manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature to add to ComfyUI.
Projects
None yet
Development

No branches or pull requests

2 participants