-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic preview method per task #6205
Comments
The |
I think this feature should be in core. Maybe you can help upstream the manager impl to core? |
Currently, the settings are saved in the However, one thing to consider in this case is that Since this change will involve modifying the backend settings, it would be good to allow for a callback to handle this. |
I don't think the setting JSON file needs to be read by the backend python server, as the frontend can pass the setting value as a request param to achieve per-request dynamic adjustment. |
Then, is it sufficient to simply expose an endpoint that allows the preview method to be dynamically configured? |
* post method `/preview_method` is added comfyanonymous#6205
Once it is reflected in the front, I will remove the feature from ComfyUI-Manager. |
Feature Idea
Each queued task can spcify its own preview method instead of relying on a static preview method set via server launch args.
This should enables selecting preview method by adjusting frontend settings without restart the server.
Existing Solutions
https://github.com/ltdrdata/ComfyUI-Manager has a UI selection to pick preview method. However, it requires restart to take effect.
Other
No response
The text was updated successfully, but these errors were encountered: