Add RX450HL fingerprint as sub to RX450H in toyota/values.py #457

chassdesk · 2018-12-08T15:45:54Z

Add RX450HL fingerprint as sub to RX450H

Confirmed on screen Be ready to take over at any time message is displayed

https://github.com/chassdesk/openpilot/blob/devel/selfdrive/car/toyota/values.py

" CAR.LEXUS_RXH: [{
36: 8, 37: 8, 166: 8, 170: 8, 180: 8, 295: 8, 296: 8, 426: 6, 452: 8, 466: 8, 467: 8, 550: 8, 552: 4, 560: 7, 562: 6, 581: 5, 608: 8, 610: 5, 643: 7, 658: 8, 713: 8, 740: 5, 742: 8, 743: 8, 800: 8, 810: 2, 812: 3, 814: 8, 830: 7, 835: 8, 836: 8, 845: 5, 863: 8, 869: 7, 870: 7, 871: 2, 898: 8, 900: 6, 902: 6, 905: 8, 913: 8, 918: 8, 921: 8, 933: 8, 944: 8, 945: 8, 950: 8, 951: 8, 953: 8, 955: 8, 956: 8, 971: 7, 975: 6, 993: 8, 998: 5, 999: 7, 1000: 8, 1001: 8, 1005: 2, 1014: 8, 1017: 8, 1020: 8, 1041: 8, 1042: 8, 1044: 8, 1056: 8, 1059: 1, 1063: 8, 1071: 8, 1077: 8, 1082: 8, 1114: 8, 1161: 8, 1162: 8, 1163: 8, 1164: 8, 1165: 8, 1166: 8, 1167: 8, 1227: 8, 1228: 8, 1235: 8, 1237: 8, 1264: 8, 1279: 8, 1552: 8, 1553: 8, 1556: 8, 1557: 8, 1568: 8, 1570: 8, 1571: 8, 1572: 8, 1575: 8, 1595: 8, 1777: 8, 1779: 8, 1808: 8, 1810: 8, 1816: 8, 1818: 8, 1840: 8, 1848: 8, 1904: 8, 1912: 8, 1940: 8, 1941: 8, 1948: 8, 1949: 8, 1952: 8, 1956: 8, 1960: 8, 1964: 8, 1986: 8, 1990: 8, 1994: 8, 1998: 8, 2004: 8, 2012: 8
},

RX450HL

{
36: 8, 37: 8, 166: 8, 170: 8, 180: 8, 295: 8, 296: 8, 426: 6, 452: 8, 466: 8, 467: 8, 550: 8, 552: 4, 560: 7, 562: 6, 581: 5, 608: 8, 610: 5, 643: 7, 658: 8, 713: 8, 742: 8, 743: 8, 800: 8, 810: 2, 812: 3, 814: 8, 830: 7, 835: 8, 836: 8, 863: 8, 865: 8, 869: 7, 870: 7, 898: 8, 900: 6, 902: 6, 905: 8, 918: 8, 921: 8, 933: 8, 944: 8, 945: 8, 950: 8, 951: 8, 953: 8, 955: 8, 956: 8, 971: 7, 975: 6, 993: 8, 998: 5, 999: 7, 1000: 8, 1001: 8, 1005: 2, 1014: 8, 1017: 8, 1020: 8, 1041: 8, 1056: 8, 1057: 8, 1059: 1, 1063: 8, 1071: 8, 1076: 8, 1077: 8, 1082: 8, 1114: 8, 1164: 8, 1165: 8, 1166: 8, 1167: 8, 1227: 8, 1228: 8, 1237: 8, 1264: 8, 1279: 8, 1552: 8, 1553: 8, 1556: 8, 1557: 8, 1568: 8, 1570: 8, 1571: 8, 1572: 8, 1575: 8, 1592: 8, 1594: 8, 1595: 8, 1649: 8, 1777: 8, 1779: 8, 1904: 8, 1912: 8, 1990: 8, 1998: 8
}],"

vanillagorillaa · 2018-12-08T20:13:21Z

Should be a PR

0.6.5.1

b2dbb50 remove toyota ipas safety code and tests (#460) a379faf White Panda's Wi-Fi setup instructions (#457) 11ef24b Improve tests (#456) fb02390 Subaru checksum counter (#455) 9a44499 Fix Subaru Legacy Torque driver bug (#454) dfa6b07 separating subary legacy safety mode from global (#452) dad5858 Chrysler: add brakepress cancellation (#451) db94a5b Added Nissan safety (#244) d7f1195 Chrysler Checksum/counter (#450) 96e535e abstract crc function (#448) 1b49d3e Hyundai: add gas disengage and tests (#447) 598074c Volkswagen safety updates: Phase 2 (#445) b2ffaae Chrysler: disengage on gas press (#442) 2ebbe36 Subaru: disengage on gas press (#446) ccf75c4 Volkswagen safety updates: Phase 1 (#444) git-subtree-dir: panda git-subtree-split: b2dbb50

c7d0d5f Volkswagen safety updates: Phase 3 (#462) 4368748 WIP: Toyota brake check. (#459) 2ef996f fix addr frequencies e063b26 Second test fix tentative 88e2593 This should fix the test replay ebb8866 Added NISSAN replay test b2dbb50 remove toyota ipas safety code and tests (#460) a379faf White Panda's Wi-Fi setup instructions (#457) 11ef24b Improve tests (#456) fb02390 Subaru checksum counter (#455) 9a44499 Fix Subaru Legacy Torque driver bug (#454) dfa6b07 separating subary legacy safety mode from global (#452) dad5858 Chrysler: add brakepress cancellation (#451) db94a5b Added Nissan safety (#244) d7f1195 Chrysler Checksum/counter (#450) 96e535e abstract crc function (#448) 1b49d3e Hyundai: add gas disengage and tests (#447) 598074c Volkswagen safety updates: Phase 2 (#445) b2ffaae Chrysler: disengage on gas press (#442) 2ebbe36 Subaru: disengage on gas press (#446) ccf75c4 Volkswagen safety updates: Phase 1 (#444) git-subtree-dir: panda git-subtree-split: c7d0d5f

0696730 Toyota: add missing offset from speed signal (#469) 5b1a8dc Filtering LKAS HUD messages (#468) 99050f4 test_spam_can_buses was missing from Nissan 0f21b19 Cleanup pedal nomenclature (#467) ceff91d Standardize brake safety tests (#465) 04809e1 Hyundai brake check (#464) 74c8ee0 Subaru brake check (#463) 4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks c7d0d5f Volkswagen safety updates: Phase 3 (#462) 4368748 WIP: Toyota brake check. (#459) 2ef996f fix addr frequencies e063b26 Second test fix tentative 88e2593 This should fix the test replay ebb8866 Added NISSAN replay test b2dbb50 remove toyota ipas safety code and tests (#460) a379faf White Panda's Wi-Fi setup instructions (#457) 11ef24b Improve tests (#456) fb02390 Subaru checksum counter (#455) 9a44499 Fix Subaru Legacy Torque driver bug (#454) dfa6b07 separating subary legacy safety mode from global (#452) dad5858 Chrysler: add brakepress cancellation (#451) db94a5b Added Nissan safety (#244) d7f1195 Chrysler Checksum/counter (#450) 96e535e abstract crc function (#448) 1b49d3e Hyundai: add gas disengage and tests (#447) 598074c Volkswagen safety updates: Phase 2 (#445) b2ffaae Chrysler: disengage on gas press (#442) 2ebbe36 Subaru: disengage on gas press (#446) ccf75c4 Volkswagen safety updates: Phase 1 (#444) git-subtree-dir: panda git-subtree-split: 0696730

d32345dd Removed prints that were used for test, but cannot be compiled for the target ba74138 Added BMW safety tests. Updated safety to limit maximum commanded target delta. Fixed safety bugs with speed scaling and other type bugs. d3cde431 Testing helpers c4c8cce7 Added dummy state to gmlan testing 9a2e2d6c Reduced repeated code e1aef2e1 Made compatible with d301a59 ed075850 Merge branch 'master' of https://github.com/commaai/panda 437d7ac2 BMW hooks. Number commaai#12 used for safety. 74c8ee0 Subaru brake check (commaai#463) 4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks c7d0d5f Volkswagen safety updates: Phase 3 (commaai#462) 4368748 WIP: Toyota brake check. (commaai#459) 2ef996f fix addr frequencies e063b26 Second test fix tentative 88e2593 This should fix the test replay ebb8866 Added NISSAN replay test b2dbb50 remove toyota ipas safety code and tests (commaai#460) a379faf White Panda's Wi-Fi setup instructions (commaai#457) 11ef24b Improve tests (commaai#456) fb02390 Subaru checksum counter (commaai#455) 9a44499 Fix Subaru Legacy Torque driver bug (commaai#454) dfa6b07 separating subary legacy safety mode from global (commaai#452) dad5858 Chrysler: add brakepress cancellation (commaai#451) db94a5b Added Nissan safety (commaai#244) f88af30e Merge remote-tracking branch 'remotes/Comma/master' d7f1195 Chrysler Checksum/counter (commaai#450) 96e535e abstract crc function (commaai#448) 1b49d3e Hyundai: add gas disengage and tests (commaai#447) 598074c Volkswagen safety updates: Phase 2 (commaai#445) b2ffaae Chrysler: disengage on gas press (commaai#442) 2ebbe36 Subaru: disengage on gas press (commaai#446) ccf75c4 Volkswagen safety updates: Phase 1 (commaai#444) d686a2ce Fixed GMLAN switch tickle interrupt git-subtree-dir: panda git-subtree-split: d32345ddcf9f70872b54886fc6c949c20dcc8650

* Introduce Model Manager to handle downloads and verification This commit introduces a new Model Manager responsible for handling model downloads, including driving and navigation application models. The manager also verifies file hashes and communicates download progress for an improved user experience. The Model Manager is asynchronous and utilizes asyncio and aiohttp for enhanced performance, including robust error handling. Impacted files in the 'cereal', 'common', 'sunnypilot', and 'system' directories have been updated accordingly. The 'ModelsFetcher' process configuration has been modified to run only when off-road, ensuring optimum resource management. This update aims to enhance code clarity, improve performance, and streamline the handling of model downloads. * "Update model management and fetching for SunnyPilot" This update refactors the model management, downloading and cache verification mechanisms of SunnyPilot. New functionalities, such as smart cache handling, have been implemented in ModelFetcher in sunnypilot/models/model_fetcher.py. Also, the model downloading process has been moved to a separate async function _download_bundle in ModelManagerSP in sunnypilot/models/model_manager.py. Hash verification of files is now performed in an async function verify_file in sunnypilot/models/model_helper.py. Changes in system parameters related to model management have been reflected in system/manager/manager.py. * Integrate download ETA calculations in model manager This commit introduces a new feature that calculates and tracks the Estimated Time of Arrival (ETA) for downloading models in the model manager component. The 'eta' property in the 'DownloadProgress' structure in 'custom.capnp' is changed from 'Float32' to 'UInt32'. In the 'model_manager.py' file, a new method '_calculate_eta' has been added to perform ETA calculations. An additional dictionary '_download_start_times' has been created to keep track of the start time of each model download. The ETA is calculated every time a portion of the model file is downloaded, and it gets updated in the 'DownloadProgress' structure. Finally, the start time is cleared after the download completes. In 'model_manager_audit.py', an additional check is added to only print downloadProgress for the downloads currently in progress. * format * no default model cache {} because it can be considered a valid json, we do not want that * Refactor typing annotations to use PEP 604 syntax. Updated type hints to adopt PEP 604 union syntax (`X | None`) and replaced `List` and `Dict` with modern built-in `list` and `dict`. This change improves consistency and readability while aligning with Python 3.10+ standards. * Simplify logging messages and remove unused imports. Removed an unused import from `model_manager.py` to improve clarity and maintainability. Also refined a log message in `model_fetcher.py` by removing unnecessary formatting for consistency. * Refactor model handling and simplify cache fallback logic. Updated type annotations for `selected_bundle` in `model_manager.py` for clarity. Streamlined cache fallback logic in `model_fetcher.py` by removing redundant conditionals while preserving functionality. These changes improve code readability and maintainability. * "Fix formatting for ModelManager_DownloadIndex retrieval Condensed parameter alignment in the get method for improved readability and adherence to style guidelines. This change does not affect functionality but ensures consistent code formatting." * Need to have main defined for process_config to be able to run it * Refactor model management to support active bundle tracking Introduce the concept of an active model bundle with a new persistent parameter and API updates. Added fields for `generation` and `environment` in model metadata, improved caching, and updated methods to manage active model states efficiently. * UI commit (commaai#515) * Refactor model management to support active bundle tracking Introduce the concept of an active model bundle with a new persistent parameter and API updates. Added fields for `generation` and `environment` in model metadata, improved caching, and updated methods to manage active model states efficiently. * Add new driving model selection feature to settings This commit introduces a new feature to the settings that allows users to select different driving models. It fetches available models and displays their download progress. The created UI also suggests a calibration reset after model download. The changes include the creation of 'SoftwarePanelSP' within 'settings.' Additionally, 'sunnypilot/SConscript' has been updated to include 'settings.cc' and 'software_panel.cc'. Changes also include localization for this feature. * Show model description during download status This update ensures the model description is displayed when a model is in the downloading state. It improves the user interface by providing real-time feedback during the download process. * Update translations for multiple languages Added new and updated translation strings in several language files, including Spanish, Arabic, Chinese (Simplified and Traditional), Turkish, Korean, Thai, Japanese, and Brazilian Portuguese. These updates include placeholder translations for new UI elements and features. * Refactor model name handling and add generation check. Replaced `bundleName` with `model_name` for better clarity in status messages. Added a generation mismatch check before showing the reset parameters dialog to avoid unnecessary prompts. * Update model handling in SoftwarePanelSP Remove unused "common/model.h" and replace "CURRENT_MODEL" with "..." as the default return value in GetModelName. Adjust logic to check for active bundles instead of selected bundles for improved accuracy. Minor text change for clarity in UI label. * Rename `GetModelName` to `GetActiveModelName` for clarity. The new name better reflects the function's purpose of retrieving the active model name, improving code readability. All relevant calls and references have been updated to ensure consistency across the codebase. * Update sunnypilot/models/model_helper.py Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> * Refactor download status handling and add 'cached' state Introduce 'cached' as a new download status and adjust relevant logic across components to support it. Simplify and streamline model status handling in the software panel for better readability and maintainability. Ensure consistent status reporting for all model types. * Update translations for multiple languages Refined and expanded translations across various languages, replacing placeholders with meaningful text. This improves clarity and user experience in the multilingual interface. * Update terminology from 'bundle' to 'model' in UI texts Replaced occurrences of 'bundle' with 'model' in button labels, dialog titles, and messages in the SoftwarePanelSP code. This improves clarity and aligns terminology with current functionality. * Update translation placeholders for model fetching texts Replaced "Fetching bundles" with "Fetching models" across multiple languages to align text placeholders with the updated functionality. Adjusted related background download messages for clarity and consistency. * cleanup * not used, and likely not needed --------- Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> * cleaning up * Update system/manager/process_config.py * Simplify model parsing and index handling logic. Refactored `ModelManager_DownloadIndex` retrieval to use the walrus operator, streamlining the conditional logic. Additionally, restructured model list initialization in `_parse_bundle` for improved readability and maintainability. These changes enhance code clarity and reduce redundancy. * `Improve error handling in model cache retrieval` Revised the `get` method to ensure it returns an empty dictionary on errors or missing data, avoiding potential `None`-related issues. Added logging for clearer diagnostics when cached model data is unavailable or retrieval fails. This improves reliability and debuggability of the model fetching process. * Fix cached model data handling by parsing JSON response Previously, cached model data was returned as a raw string, causing potential issues when using the data. The change ensures the cached data is properly parsed into JSON format before returning, improving reliability and consistency. * Adjust modelManagerSP rate and Ratekeeper frequency Reduced the rate for modelManagerSP in services and aligned the Ratekeeper frequency in model_manager.py to 0.1. * Update model fetcher URL and adjust modelManagerSP rate Updated the model fetcher URL to point to the correct resource for driving models. Adjusted the rate of modelManagerSP in both its service definition and the corresponding Ratekeeper initialization to 1 Hz for improved consistency. * Refactor model download logic for clarity and efficiency Simplify the logic for finding the model to download by combining redundant constructs into a single line. This improves code readability and reduces unnecessary variable assignments. * Fix cache keys for manual prebuilt actions because they were missing the cache when manually built * no need to log * formatting * revert ci changes * Refactor and restructure `modeld` to `models` module. Renamed `modeld` directory to `models` for clarity and consistency. Updated all references and imports to reflect the new structure. This improves maintainability and aligns with naming conventions. --------- Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: Jason Wen <[email protected]>

vanillagorillaa closed this as completed Dec 8, 2018

icmma pushed a commit to communitypilot/communitypilot that referenced this issue Oct 19, 2019

Merge pull request commaai#457 from arne182/065-clean

7c7ddee

0.6.5.1

Vaggysag pushed a commit to Vaggysag/openpilot that referenced this issue Apr 21, 2020

White Panda's Wi-Fi setup instructions (commaai#457)

a379faf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add RX450HL fingerprint as sub to RX450H in toyota/values.py #457

Add RX450HL fingerprint as sub to RX450H in toyota/values.py #457

chassdesk commented Dec 8, 2018

vanillagorillaa commented Dec 8, 2018

Add RX450HL fingerprint as sub to RX450H in toyota/values.py #457

Add RX450HL fingerprint as sub to RX450H in toyota/values.py #457

Comments

chassdesk commented Dec 8, 2018

RX450HL

vanillagorillaa commented Dec 8, 2018