Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Pedal Fingerprints for Honda and small change to Pilot / Ridgeline steerKpV and steerKiV to fit 3.3333 ratio #268

Closed
wants to merge 8 commits into from

Conversation

jfrux
Copy link

@jfrux jfrux commented Jun 20, 2018

This is based on Joel's Pedal PR but should contain changes from #251 0.4.7.1 release.

  • Updates Acura RDX Fingerprint Changes to Support Comma Pedal
  • Updates 2017 Honda Pilot Touring & 2016 Honda Pilot EX-L Fingerprint Changes to Support Comma Pedal
  • Updates Pilot & Ridgeline steerKpV and steerKiV to match the 3.3333 ratio of the other Honda vehicles.
  • Adds comments to selfdrive/car/honda/values.py to explain the Pedal changes.
  • Get response on questions from @rbiasini relating to comment formatting, and fingerprint formats.
  • Verifying the steerKpV and steerKiV changes I made on my drive home today.
  • Fix issues with minimum steering speeds not showing steering warnings. Mine is the Pilot and it's not showing the warning anymore below 12mph.

@rbiasini
Copy link
Contributor

@jfrux looks good. Can you please add a comment that 512 and 513 are reserved comma pedal? Also, I would prefer to leave the toyota changes out for now, as pedal isn't supported for toyota vehicles yet.
Other than that I verified that the changes are as intended, so it's good to go.

@rbiasini rbiasini mentioned this pull request Jun 21, 2018
@jfrux
Copy link
Author

jfrux commented Jun 22, 2018

@rbiasini Do you want the comments + the 512, 513's to be on a new line similar to how the sent messages were before?

Example:

...
CAR.PILOT: [{
  57L: 3, 145L: 8, 228L: 5, 229L: 4, 308L: 5, 316L: 8, 334L: 8, 339L: 7, 342L: 6, 344L: 8, 379L: 8, 380L: 8, 392L: 6, 399L: 7, 419L: 8, 420L: 8, 422L: 8, 425L: 8, 426L: 8, 427L: 3, 432L: 7, 463L: 8, 464L: 8, 476L: 4, 490L: 8, 506L: 8, 507L: 1, 538L: 3, 542L: 7, 545L: 5, 546L: 3, 597L: 8, 660L: 8, 773L: 7, 777L: 8, 780L: 8, 795L: 8, 800L: 8, 804L: 8, 808L: 8, 819L: 7, 821L: 5, 829L: 5, 837L: 5, 856L: 7, 871L: 8, 882L: 2, 884L: 7, 891L: 8, 892L: 8, 923L: 2, 929L: 8, 963L: 8, 965L: 8, 966L: 8, 967L: 8, 983L: 8, 985L: 3, 1027L: 5, 1029L: 8, 1036L: 8, 1039L: 8, 1064L: 7, 1088L: 8, 1089L: 8, 1108L: 8, 1125L: 8, 1296L: 8, 1424L: 5, 1600L: 5, 1601L: 8, 1612L: 5, 1613L: 5, 1616L: 5, 1618L: 5, 1668L: 5,
  # Comma Pedal Support
  512L: 6, 513L: 6, 
}],
...

OR

...
# 2017 Pilot Touring and 2016 Pilot EX-L
# with Comma Pedal Support (512L & 513L)
CAR.PILOT: [{
  57L: 3, 145L: 8, 228L: 5, 229L: 4, 308L: 5, 316L: 8, 334L: 8, 339L: 7, 342L: 6, 344L: 8, 379L: 8, 380L: 8, 392L: 6, 399L: 7, 419L: 8, 420L: 8, 422L: 8, 425L: 8, 426L: 8, 427L: 3, 432L: 7, 463L: 8, 464L: 8, 476L: 4, 490L: 8, 506L: 8, 507L: 1, 512L: 6, 513L: 6, 538L: 3, 542L: 7, 545L: 5, 546L: 3, 597L: 8, 660L: 8, 773L: 7, 777L: 8, 780L: 8, 795L: 8, 800L: 8, 804L: 8, 808L: 8, 819L: 7, 821L: 5, 829L: 5, 837L: 5, 856L: 7, 871L: 8, 882L: 2, 884L: 7, 891L: 8, 892L: 8, 923L: 2, 929L: 8, 963L: 8, 965L: 8, 966L: 8, 967L: 8, 983L: 8, 985L: 3, 1027L: 5, 1029L: 8, 1036L: 8, 1039L: 8, 1064L: 7, 1088L: 8, 1089L: 8, 1108L: 8, 1125L: 8, 1296L: 8, 1424L: 5, 1600L: 5, 1601L: 8, 1612L: 5, 1613L: 5, 1616L: 5, 1618L: 5, 1668L: 5
}],
...

Going with option 2 for now until I hear back.

@jfrux
Copy link
Author

jfrux commented Jun 22, 2018

Another question, should I add logic for Pedal support and stop_and_go variable in interface.py
You would think that cars with Pedal would need to have different settings in some areas?

@jfrux jfrux changed the title Adds Pedal Fingerprints for Honda and Toyota RAV4 Adds Pedal Fingerprints for Honda Jun 22, 2018
@jfrux jfrux changed the title Adds Pedal Fingerprints for Honda Adds Pedal Fingerprints for Honda and small change to Pilot / Ridgeline steerKpV and steerKiV to fit 3.3333 ratio Jun 22, 2018
@jfrux
Copy link
Author

jfrux commented Jun 22, 2018

Okay so we still need to warn steering on cars that have a cut off on steering at the ECU.
The pilot has a cut off on steering at 12mph so I need a warning to throw.
It appears that something changed in 0.4.6/0.4.7 that has caused this experience to go away.

It now just shows as engaged always down to zero.

@jfrux jfrux closed this Jun 26, 2018
pd0wm pushed a commit that referenced this pull request May 29, 2020
0430bfa run pre commit in ci (#268)
2ade6ee Subaru DBC update (#242)
d1185a5 Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee Add DAW (#175)
3b5cccb Fixed up cell voltage readings and added more commands (#220)
8b04493 Mazda: add missing static bits, tidy up endianness  (#263)
1247199 Add BSD_RCTA to Subaru Global (#244)
af1821f fix endianness in signal from new hyundai message
7ef4108 Add gas/brake message for hyundai EVs, from @TK211X
472aabb Subaru preglobal update (#260)
45c0d9e fix lta message (#262)
11343c1 Library cleanup (#261)
67d70cb Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: 0430bfa
pd0wm pushed a commit that referenced this pull request May 29, 2020
0430bfa run pre commit in ci (#268)
2ade6ee Subaru DBC update (#242)
d1185a5 Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee Add DAW (#175)
3b5cccb Fixed up cell voltage readings and added more commands (#220)
8b04493 Mazda: add missing static bits, tidy up endianness  (#263)
1247199 Add BSD_RCTA to Subaru Global (#244)
af1821f fix endianness in signal from new hyundai message
7ef4108 Add gas/brake message for hyundai EVs, from @TK211X
472aabb Subaru preglobal update (#260)
45c0d9e fix lta message (#262)
11343c1 Library cleanup (#261)
67d70cb Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: 0430bfa
pd0wm pushed a commit that referenced this pull request May 31, 2020
e92e743 whitespace after comma
5d33ec0 two spaces before inline comment
73685b6 fix linter complaint about whitespace around operators
b15edbc fix linter complaint about inline comment whitespace
4ac3072 clean up blank lines
0430bfa run pre commit in ci (#268)
2ade6ee Subaru DBC update (#242)
d1185a5 Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee Add DAW (#175)
3b5cccb Fixed up cell voltage readings and added more commands (#220)
8b04493 Mazda: add missing static bits, tidy up endianness  (#263)
1247199 Add BSD_RCTA to Subaru Global (#244)
af1821f fix endianness in signal from new hyundai message
7ef4108 Add gas/brake message for hyundai EVs, from @TK211X
472aabb Subaru preglobal update (#260)
45c0d9e fix lta message (#262)
11343c1 Library cleanup (#261)
67d70cb Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: e92e743
pd0wm pushed a commit that referenced this pull request May 31, 2020
4c59163 two spaces before inline comment
e92e743 whitespace after comma
5d33ec0 two spaces before inline comment
73685b6 fix linter complaint about whitespace around operators
b15edbc fix linter complaint about inline comment whitespace
4ac3072 clean up blank lines
0430bfa run pre commit in ci (#268)
2ade6ee Subaru DBC update (#242)
d1185a5 Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee Add DAW (#175)
3b5cccb Fixed up cell voltage readings and added more commands (#220)
8b04493 Mazda: add missing static bits, tidy up endianness  (#263)
1247199 Add BSD_RCTA to Subaru Global (#244)
af1821f fix endianness in signal from new hyundai message
7ef4108 Add gas/brake message for hyundai EVs, from @TK211X
472aabb Subaru preglobal update (#260)
45c0d9e fix lta message (#262)
11343c1 Library cleanup (#261)
67d70cb Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: 4c59163
pd0wm pushed a commit that referenced this pull request Jun 1, 2020
1f1ff22 enable almost all flake8 checks
4c59163 two spaces before inline comment
e92e743 whitespace after comma
5d33ec0 two spaces before inline comment
73685b6 fix linter complaint about whitespace around operators
b15edbc fix linter complaint about inline comment whitespace
4ac3072 clean up blank lines
0430bfa run pre commit in ci (#268)
2ade6ee Subaru DBC update (#242)
d1185a5 Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee Add DAW (#175)
3b5cccb Fixed up cell voltage readings and added more commands (#220)
8b04493 Mazda: add missing static bits, tidy up endianness  (#263)
1247199 Add BSD_RCTA to Subaru Global (#244)
af1821f fix endianness in signal from new hyundai message
7ef4108 Add gas/brake message for hyundai EVs, from @TK211X
472aabb Subaru preglobal update (#260)
45c0d9e fix lta message (#262)
11343c1 Library cleanup (#261)
67d70cb Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: 1f1ff22
pd0wm pushed a commit that referenced this pull request Jun 1, 2020
1f1ff22 enable almost all flake8 checks
4c59163 two spaces before inline comment
e92e743 whitespace after comma
5d33ec0 two spaces before inline comment
73685b6 fix linter complaint about whitespace around operators
b15edbc fix linter complaint about inline comment whitespace
4ac3072 clean up blank lines
0430bfa run pre commit in ci (#268)
2ade6ee Subaru DBC update (#242)
d1185a5 Toyota ACC_CONTROL PERMIT_BRAKING and ACCEL_CMT_ALT speculated definition (#258)
e6766bb Update SCC ECU Messages for OP Long Dev. (#267)
b49b9ee Add DAW (#175)
3b5cccb Fixed up cell voltage readings and added more commands (#220)
8b04493 Mazda: add missing static bits, tidy up endianness  (#263)
1247199 Add BSD_RCTA to Subaru Global (#244)
af1821f fix endianness in signal from new hyundai message
7ef4108 Add gas/brake message for hyundai EVs, from @TK211X
472aabb Subaru preglobal update (#260)
45c0d9e fix lta message (#262)
11343c1 Library cleanup (#261)
67d70cb Fix Toyota message size

git-subtree-dir: opendbc
git-subtree-split: 1f1ff22
nworb-cire pushed a commit to opgm/openpilot that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants