Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make external lemma link configurable #48

Open
mbollmann opened this issue Sep 18, 2015 · 2 comments
Open

Make external lemma link configurable #48

mbollmann opened this issue Sep 18, 2015 · 2 comments

Comments

@mbollmann
Copy link
Member

Originally reported by: Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann)


When is the external lemma link shown, and could we generalize this somehow? Pretty sure the URL is still hardcoded somewhere in there.


@mbollmann
Copy link
Member Author

mbollmann commented Apr 5, 2017

The latest commit(s) makes the URL customizable in the database, though we don't have frontend support for configuring this just yet.

@mbollmann
Copy link
Member Author

For now, I've committed a change that simply hides the icon for the link when no URLs are defined in the database. There is still no front-end for setting these URLs without directly meddling with the database, but at least users won't ever see anything about lemma links (like non-functional icons etc.) by default.

Therefore, until we add an interface for configuring the URLs, we can simply consider this an undocumented feature.

@mbollmann mbollmann changed the title Generalize external lemma link Make external lemma link configurable Jul 4, 2017
@mbollmann mbollmann added major and removed blocker labels Jul 4, 2017
@mbollmann mbollmann removed this from the Public Release milestone Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant