wil: recipe added #16701
Merged
wil: recipe added #16701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Make sure to comment in #4 for access |
Hopobcn
reviewed
Mar 30, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Chris Mc <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
prince-chrismc
previously approved these changes
Apr 10, 2023
prince-chrismc
approved these changes
Apr 10, 2023
Conan v1 pipeline ✔️All green in build 23 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 22 (
|
SSE4
approved these changes
Apr 11, 2023
MartinDelille
pushed a commit
to MartinDelille/conan-center-index
that referenced
this pull request
Apr 12, 2023
* wil recipe added * fix test_package * added _min_cpp to the recipe * fixed layot * fixes * removed camke_module_file_name/cmake_module_target_name * added patch for type conversion * Update 1.0.230202.1-0001-fix-type-conversion.patch * Update recipes/wil/all/conanfile.py Co-authored-by: Chris Mc <[email protected]> * Update recipes/wil/all/test_package/CMakeLists.txt Co-authored-by: Chris Mc <[email protected]> * Update conanfile.py * fix patch type and added source * removed gcc and clang from _compilers_min_version * fixed test_package.cpp * changed type of patch to bugfix * fixup: patch type should be portability since it adds support for vs 2017 --------- Co-authored-by: Chris Mc <[email protected]>
SpaceIm
reviewed
Apr 13, 2023
| def _compilers_minimum_version(self): | ||
| return { | ||
| "Visual Studio": "15", | ||
| "msvc": "14.1" |
There was a problem hiding this comment.
this msvc value is incorrect, it should be 191
SpaceIm
reviewed
Apr 13, 2023
Comment on lines
+41
to
+43
| # About compiler version: https://github.com/microsoft/wil/issues/207#issuecomment-991722592 | ||
| def export_sources(self): | ||
| export_conandata_patches(self) |
There was a problem hiding this comment.
why this comment is attached to export_sources?
SpaceIm
reviewed
Apr 13, 2023
Comment on lines
+85
to
+93
| # https://github.com/microsoft/wil/blob/56e3e5aa79234f8de3ceeeaf05b715b823bc2cca/CMakeLists.txt#L53 | ||
| self.cpp_info.set_property("cmake_file_name", "WIL") | ||
| self.cpp_info.set_property("cmake_target_name", "WIL::WIL") | ||
|
|
||
| # TODO: to remove in conan v2 once cmake_find_package_* generators removed | ||
| self.cpp_info.filenames["cmake_find_package"] = "WIL" | ||
| self.cpp_info.filenames["cmake_find_package_multi"] = "WIL" | ||
| self.cpp_info.names["cmake_find_package"] = "WIL" | ||
| self.cpp_info.names["cmake_find_package_multi"] = "WIL" |
There was a problem hiding this comment.
If I follow this link, I see that config file name is incorrect here, it should be lowercase:
self.cpp_info.set_property("cmake_file_name", "wil")
self.cpp_info.set_property("cmake_target_name", "WIL::WIL")
# TODO: to remove in conan v2 once cmake_find_package_* generators removed
self.cpp_info.filenames["cmake_find_package"] = "wil"
self.cpp_info.filenames["cmake_find_package_multi"] = "wil"
self.cpp_info.names["cmake_find_package"] = "WIL"
self.cpp_info.names["cmake_find_package_multi"] = "WIL"
There was a problem hiding this comment.
I must have missed the _LOWER when I was reading it 😞
prince-chrismc
added a commit
that referenced
this pull request
Apr 13, 2023
review mistakes from #16701 (comment)
3 tasks
|
Good call outs #17021 👍 |
conan-center-bot
pushed a commit
that referenced
this pull request
Apr 21, 2023
review mistakes from #16701 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: wil/1.0.230202.1
It is a dependency of the onnxruntime library on Windows: #4806
I've managed to build onnxruntime/1.7.1 on windows from the above PR with this lib added.