Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update changelog #4490

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Conversation

jgsogo
Copy link
Contributor

@jgsogo jgsogo commented Feb 5, 2021

05-February-2021 - 13:20 CET


  • closes [service] Create toc for build logs of a recipe #2145 -- We expect the new workflow to be the default with the next release (right now it will affect only some PRs we will use to validate it works as expected). The new workflow includes new messages and a better (IMHO) visualization of the logs.

  • closes [service] Logs not found in links posted by the bot #1843 -- We need to move forward, and this issue applies to the old PR workflow. Still, there is the problem of getting the logs from builds (if they were successful), but having a look at the URL pattern it should be easy to navigate them and it is something we can add to the new visualization. Let's get feedback from the new messages, we can reopen this issue if needed.

@conan-center-bot
Copy link
Collaborator

Updating docs!

@conan-center-bot
Copy link
Collaborator

Updating docs!

@prince-chrismc
Copy link
Contributor

Is this the new success message ?

#4493 (comment)

@jgsogo
Copy link
Contributor Author

jgsogo commented Feb 5, 2021

Is this the new success message ?

#4493 (comment)

Yes, and this is an error: #4489 (comment)

Hope it helps!

@SpaceIm
Copy link
Contributor

SpaceIm commented Feb 5, 2021

I didn't understand why build of opencv was failing on Windows, and I see that base path length has been increased again in CI :(

https://c3i.jfrog.io/c3i/misc/logs/pr/4489/4/opencv/4.5.0//49e6529e715c052e9cee1a5138e9d89051865579-build.txt

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppBuild.targets(321,5): error MSB3491: Could not write lines to file "opencv_features2d_AVX512_SKX.dir\Debug\opencv_f.2D0212F3.tlog\opencv_features2d_AVX512_SKX.lastbuildstate". The specified path, file name, or both are too long. The fully qualified file name must be less than 260 characters, and the directory name must be less than 248 characters. [C:\J\w\BuildSingleReference@5\.conan\data\opencv\4.5.0\_\_\build\49e6529e715c052e9cee1a5138e9d89051865579\build_subfolder\source_subfolder\modules\features2d\opencv_features2d_AVX512_SKX.vcxproj]
  Building Custom Rule C:/J/w/BuildSingleReference@5/.conan/data/opencv/4.5.0/_/_/build/49e6529e715c052e9cee1a5138e9d89051865579/source_subfolder/modules/core/CMakeLists.txt

It seems also that the error reported in #4489 (comment) is irrelevant (the real error is not at the end of the log).

But the new summary is nice ! ^^

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

@jgsogo
Copy link
Contributor Author

jgsogo commented Feb 5, 2021

Oh! The new path contains BuildSingleReference which is longer than before (it was something like PR-XXXX)... 😓 Can we use short-paths in that recipe?

@SpaceIm
Copy link
Contributor

SpaceIm commented Feb 5, 2021

@jgsogo sure, I've tried in source build, but it's forbidden by upstream CMakeLists, so yep short_paths (lot of recipes will face this issue).

@conan-center-bot conan-center-bot merged commit 9c76c57 into conan-io:master Feb 5, 2021
@jgsogo jgsogo deleted the docs/release branch February 5, 2021 17:35
@jgsogo
Copy link
Contributor Author

jgsogo commented Feb 5, 2021

If it cannot be fixed with the short_paths, we can change the name from BuildSingleReference to BSR... but c'mon, this has been Murphy's law.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[service] Create toc for build logs of a recipe [service] Logs not found in links posted by the bot
8 participants