Apply general scope options to consumer Conanfile first

[danimtb]

• Refer to the issue that supports this Pull Request: closes conan install & conan build using option patterns #2538
• If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.

The real issue was this line in configure():

self.options["*"].shared = self.options.shared

And user input with something like conan install -o *:shared=True.

Basically, options with * operator are reserved for the graph builder to be applied to requirements when graph is complete. The option with * is not applied initially to the consumer conanfile and when it hits the line above in configure, changes the general scope option to its default value (shared=False).

• I've read the Contributing guide.
• I've followed the PEP8 style guides for Python code.
• I've opened another PR in the Conan docs repo to the develop branch, documenting this one. Also adding a description of the changes in the changelog.rst file. https://github.com/conan-io/docs

[memsharded]

This test looks a bit complex for the use case. Just defining -o *:shared in the command line should be enough to check it, wouldn't it?

[danimtb]

No. this is in fact the real issue this is testing. Read the description in the PR comments

[lasote]

But, why would you type self.options["*"].shared = self.options.shared in the configure? I don't get it. Without that line, does everything work as expected?

[danimtb]

because you want to build your hole dependency graph with that option. So when the consumer project declares that option, all dependencies are the same.

I know it makes no sense to have that line and use the command:

conan install -o *:shared=True

You'd rather use:

conan install -o consumer:shared=True

First does NOT work, second does.

But the weird thing for the user is that it also works for:

conan install -o shared=True

---

Without that line, does everything work as expected?

Yes