Apply general scope options to consumer Conanfile first

conans/client/loader.py

@@ -54,6 +54,7 @@ def load_conan(self, conanfile_path, output, consumer=False, reference=None, loc
             result._env_values.update(self._env_values)
 
             if consumer:
+                self._user_options[result.name].update(self._user_options["*"])
                 self._user_options.descope_options(result.name)
                 result.options.initialize_upstream(self._user_options, local=local)
                 self._user_options.clear_unscoped_options()

conans/model/options.py

@@ -483,9 +483,8 @@ def propagate_upstream(self, package_values, down_ref, own_ref, pattern_options)
 
 
 class Options(object):
-    """ all options of a package, both its own options and the upstream
-    ones.
-    Owned by conanfile
+    """ All options of a package, both its own options and the upstream ones.
+    Owned by ConanFile.
     """
     def __init__(self, options):
         assert isinstance(options, PackageOptions)

conans/test/integration/options_test.py

@@ -64,3 +64,59 @@ class ConanLib(ConanFile):
                       client.user_io.out)
         conaninfo = load(os.path.join(client.current_folder, CONANINFO))
         self.assertNotIn("zlib:shared=True", conaninfo)
+
+    def general_scope_options_test(self):
+        # https://github.com/conan-io/conan/issues/2538
+        client = TestClient()
+        conanfile_libA = """
+from conans import ConanFile
+
+class LibA(ConanFile):
+    name = "libA"
+    version = "0.1"
+    options = {"shared": [True, False]}
+    default_options= "shared=False"
+
+    def configure(self):
+        self.output.info("shared=%s" % self.options.shared)
+    """
+        conanfile_libB = """
+from conans import ConanFile
+
+class LibB(ConanFile):
+    name = "libB"
+    version = "0.1"
+    options = {"shared": [True, False]}
+    default_options= "shared=False"
+    requires = "libA/0.1@danimtb/testing"
+
+    def configure(self):
+        self.options["*"].shared = self.options.shared
+        self.output.info("shared=%s" % self.options.shared)
+    """
+        client.save({"conanfile_liba.py": conanfile_libA,
+                     "conanfile_libb.py": conanfile_libB})
+
+        for without_configure_line in [True, False]:
+            client.save({"conanfile_liba.py": conanfile_libA})
+
+            if without_configure_line:
+                client.save({"conanfile_libb.py": conanfile_libB.replace(
+                    "        self.options[\"*\"].shared = self.options.shared", "")})
+            else:
+                client.save({"conanfile_libb.py": conanfile_libB})
+
+            # Test info
+            client.run("export conanfile_liba.py danimtb/testing")
+            client.run("info conanfile_libb.py -o *:shared=True")
+            self.assertIn("PROJECT: shared=True", client.out)
+            self.assertIn("libA/0.1@danimtb/testing: shared=True", client.out)
+            # Test create
+            client.run("create conanfile_liba.py danimtb/testing -o *:shared=True")
+            client.run("create conanfile_libb.py danimtb/testing -o *:shared=True")
+            self.assertIn("libB/0.1@danimtb/testing: shared=True", client.out)
+            self.assertIn("libA/0.1@danimtb/testing: shared=True", client.out)
+            # Test install
+            client.run("install conanfile_libb.py -o *:shared=True")
+            self.assertIn("PROJECT: shared=True", client.out)
+            self.assertIn("libA/0.1@danimtb/testing: shared=True", client.out)