Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup openssl 1.1.1 workarounds #7

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Dec 6, 2022

They were added in conda-forge/staged-recipes#20432 (comment), but now openssl 3 migration should have progressed enough so that they are not necessary anymore.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge-admin, please rerender

@traversaro
Copy link
Contributor Author

Tests are failing due to:

export PREFIX=/home/conda/feedstock_root/build_artifacts/bipedal-locomotion-framework_1670329826819/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho
export SRC_DIR=/home/conda/feedstock_root/build_artifacts/bipedal-locomotion-framework_1670329826819/test_tmp
import: 'bipedal_locomotion_framework'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/bipedal-locomotion-framework_1670329826819/test_tmp/run_test.py", line 2, in <module>
    import bipedal_locomotion_framework
  File "/home/conda/feedstock_root/build_artifacts/bipedal-locomotion-framework_1670329826819/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.10/site-packages/bipedal_locomotion_framework/__init__.py", line 1, in <module>
    from .bindings import *
ImportError: arg(): could not convert default argument 'mixed_velocity: manif::SE3Tangent<double>' in method '<class 'bipedal_locomotion_framework.bindings.ik.SE3Task'>.set_set_point' into a Python object (type not registered yet?)
Tests failed for bipedal-locomotion-framework-python-0.10.0-py310h83a6ccd_3.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING:conda_build.build:Tests failed for bipedal-locomotion-framework-python-0.10.0-py310h83a6ccd_3.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: bipedal-locomotion-framework-python-0.10.0-py310h83a6ccd_3.conda

Probably this is a problem of the overconstraining the compiler version by pybind11, see ami-iit/bipedal-locomotion-framework#386 .

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants