Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for bipedal-locomotion-framework #20432

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Sep 14, 2022

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bipedal-locomotion-framework) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bipedal-locomotion-framework) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but couldn't find any.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bipedal-locomotion-framework) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

traversaro commented Oct 11, 2022

The python bindings are failing with:

Packaging bipedal-locomotion-framework-python
Reloading output folder: /home/conda/staged-recipes/build_artifacts
Mamba failed to solve:
 - pybind11-abi 4.* hd8ed1ab_3
 - wheel 0.37.1.* pyhd8ed1ab_0
 - pip 22.2.2.* pyhd8ed1ab_0
 - pybind11-global 2.10.0.* py310hbf28c38_0
 - pybind11 2.10.0.* py310hbf28c38_0
 - libbipedal-locomotion-framework 0.9.0.* h21f30a8_0

with channels:
 - local
 - conda-forge
 - conda-forge

The reported errors are:
- Encountered problems while solving:
-   - package libbipedal-locomotion-framework-0.9.0-h21f30a8_0 requires pcl >=1.12.1,<1.12.2.0a0, but none of the providers can be installed
- 

Not sure it is trying to install openssl 3.0.5 . However, the problem is that there are no qt build with openssl, so eventually this should be fixed by conda-forge/qt-main-feedstock#50 .

@traversaro
Copy link
Contributor Author

@GiulioRomualdi are you interested in mantaining this recipe?

@GiulioRomualdi
Copy link
Contributor

@GiulioRomualdi are you interested in mantaining this recipe?

Yes sure!

@traversaro
Copy link
Contributor Author

I forgot to package a dependency, unicycle-footstep-planner.

@traversaro
Copy link
Contributor Author

I forgot to package a dependency, unicycle-footstep-planner.

I proposed a recipe for this missing package in #20752 .

@traversaro traversaro closed this Oct 20, 2022
@traversaro traversaro reopened this Oct 20, 2022
@traversaro
Copy link
Contributor Author

traversaro commented Oct 26, 2022

Linux and macOS tests are failing with:

import: 'bipedal_locomotion_framework'
Traceback (most recent call last):
  File "/home/conda/staged-recipes/build_artifacts/bipedal-locomotion-framework_1666394492512/test_tmp/run_test.py", line 2, in <module>
    import bipedal_locomotion_framework
  File "/home/conda/staged-recipes/build_artifacts/bipedal-locomotion-framework_1666394492512/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.9/site-packages/bipedal_locomotion_framework/__init__.py", line 1, in <module>
    from .bindings import *
ImportError: arg(): could not convert default argument 'mixed_velocity: manif::SE3Tangent<double>' in method '<class 'bipedal_locomotion_framework.bindings.ik.SE3Task'>.set_set_point' into a Python object (type not registered yet?)
Tests failed for bipedal-locomotion-framework-python-0.9.0-py39hac7f59c_0.tar.bz2 - moving package to /home/conda/staged-recipes/build_artifacts/broken

Possibly related to ami-iit/bipedal-locomotion-framework#386 .

@traversaro
Copy link
Contributor Author

By looking a bit more it seems taht or some raeson manifpy: 0.0.4-py39h965f727_7 is used, instead of the latest _8 build, so the issue is due to ami-iit/bipedal-locomotion-framework#545 (comment), that was fixed by conda-forge/manif-feedstock#21 . I re-triggered a manif build (conda-forge/manif-feedstock#23) so that the a build with the latest pinned numpy is produced, to see if this solves the problems.

@traversaro traversaro closed this Oct 26, 2022
@traversaro traversaro reopened this Oct 26, 2022
@traversaro
Copy link
Contributor Author

Now test is failing with:

The reported errors are:
- Encountered problems while solving:
-   - package libbipedal-locomotion-framework-0.9.0-h42d203b_0 requires vtk >=9.1.0,<9.1.1.0a0, but none of the providers can be installed

probably again some issue of ongoing migrations.

@traversaro
Copy link
Contributor Author

Now test is failing with:

The reported errors are:
- Encountered problems while solving:
-   - package libbipedal-locomotion-framework-0.9.0-h42d203b_0 requires vtk >=9.1.0,<9.1.1.0a0, but none of the providers can be installed

probably again some issue of ongoing migrations.

To avoid the problem, we temporary disable the PCL dependency. We can work on enabling once the recipe has been merged.

@traversaro
Copy link
Contributor Author

By looking a bit more it seems taht or some raeson manifpy: 0.0.4-py39h965f727_7 is used, instead of the latest _8 build, so the issue is due to ami-iit/bipedal-locomotion-framework#545 (comment), that was fixed by conda-forge/manif-feedstock#21 . I re-triggered a manif build (conda-forge/manif-feedstock#23) so that the a build with the latest pinned numpy is produced, to see if this solves the problems.

Even by using the latest manifpy build, the error is still there.

@traversaro
Copy link
Contributor Author

By looking a bit more it seems taht or some raeson manifpy: 0.0.4-py39h965f727_7 is used, instead of the latest _8 build, so the issue is due to ami-iit/bipedal-locomotion-framework#545 (comment), that was fixed by conda-forge/manif-feedstock#21 . I re-triggered a manif build (conda-forge/manif-feedstock#23) so that the a build with the latest pinned numpy is produced, to see if this solves the problems.

Even by using the latest manifpy build, the error is still there.

I think the error may be much simpler. Basically the manif type are loaded by this line: https://github.com/ami-iit/bipedal-locomotion-framework/blob/bb20f7e4a267a0eb5c377f43a3e7c278ac48ce4b/bindings/python/bipedal_locomotion_framework.cpp.in#L74 , but that is only compiled in if FRAMEWORK_USE_manif is set at the CMake level, but we are not considering that in ami-iit/bipedal-locomotion-framework#564 .

@traversaro
Copy link
Contributor Author

@conda-forge/core the recipe is ready for review

@xhochy xhochy merged commit e3f6082 into conda-forge:main Oct 28, 2022
@traversaro
Copy link
Contributor Author

Thanks @xhochy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants