Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coin-or stack #2080

Merged
merged 5 commits into from
Nov 4, 2021
Merged

Add coin-or stack #2080

merged 5 commits into from
Nov 4, 2021

Conversation

BastianZim
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Closes #1991

cc @wolfv

@BastianZim BastianZim requested a review from a team as a code owner October 30, 2021 16:43
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

BastianZim and others added 2 commits October 30, 2021 19:05
Co-authored-by: Isuru Fernando <[email protected]>
@BastianZim BastianZim requested a review from isuruf October 30, 2021 17:07
@isuruf
Copy link
Member

isuruf commented Oct 30, 2021

We should first make coincbc package a meta package before using the new coin-or-cbc package.

@BastianZim
Copy link
Member Author

BastianZim commented Oct 30, 2021

@isuruf Should coincbc be an output of coin-or-cbc and coincbc-feedstock be archived, or should coincbc be empty and depend on coin-or-cbc?

@isuruf
Copy link
Member

isuruf commented Oct 30, 2021

First option is preferred.

@BastianZim
Copy link
Member Author

Has been introduced in conda-forge/coin-or-cbc-feedstock#11

@BastianZim
Copy link
Member Author

@isuruf Would you mind merging this now?

Co-authored-by: Isuru Fernando <[email protected]>
@BastianZim BastianZim requested a review from isuruf November 4, 2021 13:54
@isuruf isuruf merged commit ec10bec into conda-forge:master Nov 4, 2021
@BastianZim
Copy link
Member Author

Thank you!

@BastianZim BastianZim deleted the patch-1 branch November 4, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coin-or stack
3 participants