Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cysignals v1.11.0 #35

Merged
merged 12 commits into from
Dec 2, 2021
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
    Checklist before merging this PR:
  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1506789017, please use this URL for debugging

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

  • cython

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

instead of doing it in build.sh.

Was there a good reason why this must happen in build.sh?

It is also unclear why this change is necessary at all.
@saraedum
Copy link
Member

saraedum commented Dec 2, 2021

On osx-arm64, cythonized files are compiled with -arch x86_64 which is wrong. (fixed.)

On aarch64, the tests fail. Probably with exit code 23 which leads to no explicit error output. What is this exit code used for? Maybe that one is used when there are failing tests so these failing tests should have printed some output on their own?

@saraedum saraedum force-pushed the 1.11.0_h11b170 branch 2 times, most recently from b4deb69 to 30db077 Compare December 2, 2021 06:12
to debug which aarch64 fails on Azure now.
@saraedum saraedum added the automerge Merge the PR when CI passes label Dec 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: failed

Thus the PR was not passing and not merged.

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Dec 2, 2021
@saraedum saraedum added the automerge Merge the PR when CI passes label Dec 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • travis: passed
  • azure: failed

Thus the PR was not passing and not merged.

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Dec 2, 2021
@saraedum saraedum added the automerge Merge the PR when CI passes label Dec 2, 2021
these tests probably never passed on aarch64 but before we did not run
the tests in CI.

See conda-forge#37.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2021

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Dec 2, 2021
@saraedum saraedum merged commit 3ad8f99 into conda-forge:master Dec 2, 2021
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 1.11.0_h11b170 branch December 2, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants