Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple ogre #1

Merged
merged 5 commits into from
Mar 24, 2021
Merged

Multiple ogre #1

merged 5 commits into from
Mar 24, 2021

Conversation

Tobias-Fischer
Copy link
Contributor

@Tobias-Fischer Tobias-Fischer commented Mar 23, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@Tobias-Fischer
Copy link
Contributor Author

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Tobias-Fischer
Copy link
Contributor Author

I think the CDN still needs to propagate .. the libignition-rendering build for ogre1.10 is not yet found

@Tobias-Fischer
Copy link
Contributor Author

@conda-forge-admin, please restart CI

@Tobias-Fischer
Copy link
Contributor Author

Win fails because https://github.com/ignitionrobotics/ign-gui/blob/ign-gui4/tools/check_test_ran.py tries to "grep" which is not available on Windows.

@traversaro
Copy link
Contributor

Strange, I thought I had added -E check_ to the ctest invocation on Windows. Given that this problem is just a Python script that was not properly updated and not an actual test failing, I think we can just added a -E check_.

@traversaro
Copy link
Contributor

Win fails because https://github.com/ignitionrobotics/ign-gui/blob/ign-gui4/tools/check_test_ran.py tries to "grep" which is not available on Windows.

Workarounded in a951b60, opened upstream issue in gazebosim/gz-gui#198 (probably it is just sufficient to apply patch gazebosim/gz-math@69d881d#diff-2d6a060081b4c12efdbe4f12e846ead21821236e834f41885a04e41e884687c2).

@Tobias-Fischer
Copy link
Contributor Author

Fix #2. Thanks @traversaro. This is ready to be merged.

@traversaro traversaro merged commit 7e65166 into conda-forge:master Mar 24, 2021
@traversaro
Copy link
Contributor

Thanks @Tobias-Fischer !

@traversaro
Copy link
Contributor

By the way, this PR also permits to upload Windows binaries, as for some reason #2 was not occuring in staged-recipes, but post merge made the Windows build fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants